Skip to content

feat: unify initial text/html iOS emitting with Android #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szydlovsky merged 1 commit into from
Nov 20, 2025
Merged

feat: unify initial text/html iOS emitting with Android #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ios/EnrichedTextInputView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ - (void)setDefaults {
_recentlyActiveMentionRange = NSMakeRange(0, 0);
recentlyChangedRange = NSMakeRange(0, 0);
_recentlyEmittedString = @"";
_recentlyEmittedHtml = @"";
_recentlyEmittedHtml = @"<html>\n<p></p>\n</html>";
_emitHtml = NO;
blockEmitting = NO;
_emitFocusBlur = YES;
Expand Down Expand Up @@ -1052,6 +1052,12 @@ - (void)anyTextMayHaveBeenModified {
[h3Style handleImproperHeadings];
}

// mentions removal management
MentionStyle *mentionStyleClass = (MentionStyle *)stylesDict[@([MentionStyle getStyleType])];
if(mentionStyleClass != nullptr) {
[mentionStyleClass handleExistingMentions];
}

// placholder management
if(!_placeholderLabel.hidden && textView.textStorage.string.length > 0) {
[self setPlaceholderLabelShown:NO];
Expand All @@ -1060,12 +1066,6 @@ - (void)anyTextMayHaveBeenModified {
}

if(![textView.textStorage.string isEqualToString:_recentlyEmittedString]) {
// mentions removal management
MentionStyle *mentionStyleClass = (MentionStyle *)stylesDict[@([MentionStyle getStyleType])];
if(mentionStyleClass != nullptr) {
[mentionStyleClass handleExistingMentions];
}

// modified words handling
NSArray *modifiedWords = [WordsUtils getAffectedWordsFromText:textView.textStorage.string modificationRange:recentlyChangedRange];
if(modifiedWords != nullptr) {
Expand All @@ -1087,13 +1087,13 @@ - (void)anyTextMayHaveBeenModified {
// emit onChangeText event
auto emitter = [self getEventEmitter];
if(emitter != nullptr) {
// set the recently emitted string only if the emitter is defined
_recentlyEmittedString = stringToBeEmitted;

emitter->onChangeText({
.value = [stringToBeEmitted toCppString]
});
}

// set the recently emitted string
_recentlyEmittedString = stringToBeEmitted;
}

// update height on each character change
Expand Down
Loading