Skip to content

feat: add support for inline image on iOS - #271

Merged
kacperzolkiewski merged 11 commits into
mainfrom
add-inline-image-ios
Nov 25, 2025
Merged

kacperzolkiewski merged 11 commits into
mainfrom
add-inline-image-ios

Conversation

@kacperzolkiewski

@kacperzolkiewski kacperzolkiewski commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator

Summary

Fixes: #170
Add support for inline image

Test Plan

Run Example app and play with inline image

Screenshots / Videos

Nagranie.z.ekranu.2025-11-21.o.10.05.25.mov

Compatibility

OS Implemented
iOS
Android

@kacperzolkiewski
kacperzolkiewski marked this pull request as ready for review November 21, 2025 09:08
Comment thread ios/EnrichedTextInputView.mm

@szydlovsky szydlovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally works fine. Left a few technical comments. The blocking/conflicting needs to be discussed because I feel like it's not too clear right now

Comment thread README.md
Comment thread ios/EnrichedTextInputView.mm Outdated
Comment thread ios/inputParser/InputParser.mm Outdated
Comment thread ios/styles/ImageStyle.mm
Comment thread ios/utils/LayoutManagerExtension.mm Outdated
Comment thread ios/EnrichedTextInputView.mm Outdated
Comment thread ios/EnrichedTextInputView.mm Outdated

@exploIF exploIF left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread example/src/App.tsx Outdated
@kacperzolkiewski
kacperzolkiewski merged commit 5c634fd into main Nov 25, 2025
9 of 10 checks passed
@kacperzolkiewski
kacperzolkiewski deleted the add-inline-image-ios branch November 25, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Would really love to use this library but deeply need inline image support for iOS

3 participants