fix: iOS links - #272
Merged
Merged
fix: iOS links#272
Conversation
kacperzolkiewski
approved these changes
Nov 20, 2025
exploIF
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firstly, it turns out that something in the internal implementation of
attribute:atIndex:longestEffectiveRange:inRangehas been changed and if no attribute has been found, longest effective range is set to whole range we are searching in. This resulted in links wrongly returning that their range is whole input and it had implications in fonts and foreground colors randomly breaking when applying links.Secondly, improved detecting links. The detection made after updating an automatic link didn't take recently emitted link into consideration and ran the event even if the automatic link wasn't updated - resulting in a double emit. The text when applying link was also double emitted because
LinkStyle'saddLinkredundantly calledanyTextMayHaveBeenModifiedTest Plan
Screenshots / Videos
--
Compatibility