fix: iOS nested tags - #274
Merged
Merged
Conversation
kacperzolkiewski
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns out nested tags logic isn't perfect on iOS yet.
Adding a styling like this:
(bold and strikethrough, then only strikethrough, then again both of them)
Results in an invalid html:
The
stag should have been closed before anotherbtag and opened again after it.This PR fixes that situation, making sure all tags that were active index ago and are still active on the index under consideration, if inner to a newly opened tag, will be closed and re-opened.
Test Plan
Try re-creating the text described in the Summary.
See that it produces a valid html now:
Screenshots / Videos
--
Compatibility