-
Notifications
You must be signed in to change notification settings - Fork 66
feat: get HTML value imperatively #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
exploIF
merged 7 commits into
software-mansion:main
from
qoobes:add-imperative-html-method
Dec 15, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
be538d3
feat: add imperative html method
088b596
fix: android missing import
a4972a0
Merge branch 'main' into add-imperative-html-method
qoobes 953f619
Update src/EnrichedTextInput.tsx
qoobes 7fbb811
feat: implement suggested fixes for getHTML method
9cbc6fc
chore: tiny improvements, fix missing android import
exploIF e50ff47
fix: lint clang
exploIF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
android/src/main/java/com/swmansion/enriched/events/OnRequestHtmlResultEvent.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package com.swmansion.enriched.events | ||
|
|
||
| import com.facebook.react.bridge.Arguments | ||
| import com.facebook.react.bridge.WritableMap | ||
| import com.facebook.react.uimanager.events.Event | ||
|
|
||
| class OnRequestHtmlResultEvent( | ||
|
exploIF marked this conversation as resolved.
|
||
| surfaceId: Int, | ||
| viewId: Int, | ||
| private val requestId: Int, | ||
| private val html: String?, | ||
| private val experimentalSynchronousEvents: Boolean | ||
| ) : Event<OnRequestHtmlResultEvent>(surfaceId, viewId) { | ||
|
|
||
| override fun getEventName(): String = EVENT_NAME | ||
|
|
||
| override fun getEventData(): WritableMap { | ||
| val eventData: WritableMap = Arguments.createMap() | ||
| eventData.putInt("requestId", requestId) | ||
| if (html != null) { | ||
| eventData.putString("html", html) | ||
| } else { | ||
| eventData.putNull("html") | ||
| } | ||
| return eventData | ||
| } | ||
|
|
||
| override fun experimental_isSynchronous(): Boolean = experimentalSynchronousEvents | ||
|
|
||
| companion object { | ||
| const val EVENT_NAME: String = "onRequestHtmlResult" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.