fix: <br> parsing inside codeblock and blockquote - #319
Merged
Merged
Conversation
kacperzolkiewski
force-pushed
the
fix-blockquote-parsing
branch
from
December 11, 2025 08:19
9af01cc to
477d9df
Compare
kacperzolkiewski
requested review from
exploIF and
szydlovsky
and removed request for
szydlovsky
December 11, 2025 08:20
kacperzolkiewski
marked this pull request as ready for review
December 11, 2025 08:20
Collaborator
Author
|
Sorry, but I forget about @kacperzolkiewski prefix in branch name 😞 |
szydlovsky
reviewed
Dec 12, 2025
szydlovsky
left a comment
szydlovsky
left a comment
Collaborator
There was a problem hiding this comment.
Some things to check out
This reverts commit 8c43d4e.
exploIF
approved these changes
Dec 17, 2025
szydlovsky
approved these changes
Dec 17, 2025
szydlovsky
left a comment
szydlovsky
left a comment
Collaborator
There was a problem hiding this comment.
Solid, just two small NITs
Co-authored-by: Mikołaj Szydłowski <9szydlowski9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #207
Test Plan
Try with various htmls:
Set input's valuebuttonand or
Run test case from: #207
Screenshots / Videos
Screen.Recording.2025-12-11.at.09.00.22.mov
Compatibility