fix: padding applied as margin - #358
Closed
kacperzolkiewski wants to merge 3 commits into
Closed
kacperzolkiewski wants to merge 3 commits into
kacperzolkiewski wants to merge 3 commits into
Conversation
kacperzolkiewski
marked this pull request as ready for review
January 9, 2026 12:42
kacperzolkiewski
requested review from
exploIF and
szydlovsky
and removed request for
szydlovsky
January 9, 2026 12:42
Contributor
|
In general, this fix is pretty much the same as what I did in #339 @kacperzolkiewski , @szydlovsky Can we proceed with my PR instead, since this one won't react to the screen rotation and dynamic size changes + it will calculate size when width and height are not actually changed? A small example: " - indicates text view bounds "Some text | " If I type a text in the caret position, it won't produce a new line, it won't increase the text view width(if we set it as a static value), and there is no sense in recalculating width and height for the shadow node. |
Collaborator
Author
|
Hi @IvanIhnatsiuk, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #332
updateLayoutMetricsto correctly applypaddingfor_placeholderLabelconstraints.boundingRectWithSizeto[textView sizeThatFits:]to ensure measurement matches actual rendering logic exactly._performRelayoutthat caused scroll flickering.ensureCursorIsVisibleto fix cursor visibility when styles (like H1) change the text height dynamically.Test Plan
Screenshots / Videos
Before:
Screen.Recording.2026-01-09.at.13.22.58.mov
After:
Screen.Recording.2026-01-09.at.13.20.35.mov
Compatibility