-
Notifications
You must be signed in to change notification settings - Fork 67
feat(ios): add textAlignment #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
ccdce63
feat(ios): add textAlignment
kacperzolkiewski 9e157ed
feat: add parsing from html into input
kacperzolkiewski 178c83d
feat: separate alignment logic to AlignmentUtils
kacperzolkiewski 6823e42
fix: android build
kacperzolkiewski 6640463
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski 6d2bf85
fix: layout for ZWS
kacperzolkiewski 7dc4737
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski 51b54d5
fix: add alignment to Toolbar
kacperzolkiewski a0e9f64
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski d978723
fix: review changes
kacperzolkiewski 962b042
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski 161ff8c
fix: resolve conflicts in parser
kacperzolkiewski e62df66
fix: alignment after mataatributes remake
kacperzolkiewski e21de1f
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski 869ce6d
fix: refactor alignment to style
kacperzolkiewski 76734f3
fix: removing checkboxList
kacperzolkiewski e7d5b8e
fix: preserve aignment during typing attributes reset
kacperzolkiewski bea7294
fix: alignment detection
kacperzolkiewski 521fdc2
fix: remove unused code
kacperzolkiewski b09f68b
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski aef3a57
fix: cursor alignment for empty lines
kacperzolkiewski 98d7873
fix: placeholder alignment
kacperzolkiewski 8f81868
fix: linting
kacperzolkiewski 3c8b79e
test: add e2e tests for alignment
kacperzolkiewski 9e6b747
Merge branch 'main' into @kacperzolkiewski/text-alignment
kacperzolkiewski 180e643
Update ios/utils/TextListUtils.h
kacperzolkiewski 8d5ee49
Update .maestro/enrichedInput/flows/paragraph_styles_alignment_visual…
kacperzolkiewski f94e12b
Update ios/enrichedInputTextView/EnrichedInputTextView/EnrichedInputT…
kacperzolkiewski 611eded
Update ios/utils/TextListUtils.h
kacperzolkiewski a3a4d9c
Update ios/utils/ParagraphAttributesUtils.mm
kacperzolkiewski ee57d0c
Update ios/utils/TextListUtils.h
kacperzolkiewski 555181a
fix: review changes
kacperzolkiewski 9a965d1
fix: parser
kacperzolkiewski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
.maestro/enrichedInput/flows/paragraph_styles_alignment_visual.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| appId: swmansion.enriched.example | ||
| tags: | ||
| - ios-only | ||
| --- | ||
| # Visually validates text alignment rendering | ||
| - launchApp | ||
|
|
||
| - tapOn: | ||
| id: 'toggle-screen-button' | ||
|
|
||
| - tapOn: | ||
| id: 'editor-input' | ||
|
|
||
| # Left-aligned text | ||
| - inputText: 'Left aligned' | ||
| - pressKey: Enter | ||
|
|
||
| # Centre-aligned | ||
| - tapOn: | ||
| id: 'toolbar-align-center' | ||
| - inputText: 'Centre aligned' | ||
| - pressKey: Enter | ||
|
|
||
| # Heading 4 | ||
| - tapOn: | ||
| id: 'toolbar-heading-6' | ||
| - inputText: 'Heading 6' | ||
| - pressKey: Enter | ||
|
|
||
| # Right-aligned text | ||
| - tapOn: | ||
| id: 'toolbar-align-right' | ||
| - inputText: 'Right aligned' | ||
| - pressKey: Enter | ||
|
|
||
| # List with right-aligned items | ||
| - tapOn: | ||
| id: 'toolbar-ordered-list' | ||
| - inputText: 'Element 1' | ||
| - pressKey: Enter | ||
| - inputText: 'Element 2' | ||
|
|
||
| - runFlow: | ||
| file: '../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'paragraph_styles_alignment' | ||
Binary file added
BIN
+32.6 KB
.maestro/enrichedInput/screenshots/ios/paragraph_styles_alignment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| appId: swmansion.enriched.example | ||
| --- | ||
| # Validates that text alignment is displayed correctly | ||
| - launchApp | ||
|
|
||
| - tapOn: | ||
| id: 'toggle-screen-button' | ||
|
|
||
| - tapOn: | ||
| id: 'toggle-enriched-text-screen-button' | ||
|
|
||
| - runFlow: | ||
| file: '../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: > | ||
| <html> | ||
| <p>Left aligned</p> | ||
| <p style="text-align: center">Centre aligned</p> | ||
| <h6 style="text-align: center">Heading 6</h6> | ||
| <p style="text-align: right">Right aligned</p> | ||
| <ol style="text-align: right"> | ||
| <li>Element 1</li> | ||
| <li>Element 2</li> | ||
| </ol> | ||
| </html> | ||
|
|
||
| - runFlow: | ||
| file: '../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'alignment_visual' |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kacperzolkiewski marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.