fix: revert "fix(iOS): proper layout calculation #339" - #417
Conversation
|
@szydlovsky Could you give more context on what goes wrong?
NOTE: If you revert these changes, then please test this flow:
|
|
@IvanIhnatsiuk The bug I mentioned is pretty difficult to reproduce. I thought the issue might have been the input just hijacking the scrolling gesture, so I decided to use See the following scenario: We want an input that can be any size, and should always expand instead of scrolling (exactly what's needed in case of input being inside a scroll that is inside a bottom sheet), so naturally Here's an example from the current main, example app with just removed Screen.Recording.2026-02-16.at.14.42.43.movAnd here's the same setup but from the branch that reverses the PR: Screen.Recording.2026-02-16.at.14.47.58.movI believe it's enough for having the PR reverted for now and outweighs just not preserving scroll position on navigation. EDIT: if |
|
@szydlovsky okay 🙂 |
Reverts #339 due to a iOS layout bug we found;
The input sometimes becomes unscrollable when it's inside a scrollable bottom sheet (
@gorhom/bottom-sheet), with aKeyboardAwareScrollView(react-native-keyboard-controller) turned into a proper bottom-sheet-scrollview component.The bug doesn't appear when testing a commit before the PR, but does happen on the exact merge commit of the said PR.