fix(web): headings font color inheritance - #710
Merged
hejsztynx merged 1 commit intoJul 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes heading (h1–h6) text color on web so headings inside the enriched editor/view consistently inherit the surrounding editor text color, instead of being overridden by app-level/global h1 { color: ... } rules.
Changes:
- Add
color: inherit;toh1–h6rules scoped under.eti-editorand.et-viewto ensure heading color follows the editor/view container styling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hejsztynx
deleted the
@ksienkiewicz/fix-web-heading-font-color-inheritance
branch
July 20, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The color of the headings -
h1,h2, ..., was not properly defined. You could create a CSS rule e.gh1 { color: 'white' }in an app's higher context and that color would get applied, it did not use the editor'scolor. Now it properly inherits it.Compatibility
Checklist