fix: removing conflicting styles - #721
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a formatting edge case when applying paragraph-level styles via text shortcuts (e.g., codeblock) so that conflicting inline styles (like bold/italic) are removed appropriately rather than being retained on the line/paragraph.
Changes:
- iOS: remove conflicting styles across the entire paragraph (not just at the cursor) before applying the block/paragraph style.
- Android: route paragraph-shortcut style application through
verifyAndToggleStyle(...)so conflicts/blocks are verified and conflicting styles are removed consistently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ios/utils/ShortcutsUtils.mm | Expands conflict-removal range to the full paragraph before applying a paragraph/block style shortcut. |
| android/src/main/java/com/swmansion/enriched/textinput/utils/ShortcutsHandler.kt | Uses verifyAndToggleStyle when applying shortcut styles to ensure conflicts are handled during toggling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exploIF
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix removing conflicting styles when applying paragraph style through shortcut
Test Plan
Screenshots / Videos
Before:
Screen.Recording.2026-07-22.at.13.49.12.mov
After:
Screen.Recording.2026-07-22.at.13.49.50.mov
Compatibility
Checklist