Skip to content

fix(ios): stale head indent on selection change to a trailing newline #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejsztynx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): stale head indent on selection change to a trailing newline #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ios/enrichedInputTextView/EnrichedInputTextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ - (CGRect)caretRectForPosition:(UITextPosition *)position {
rect.origin.x = (containerWidth - rect.size.width) / 2.0;
} else if (alignment == NSTextAlignmentRight) {
rect.origin.x = containerWidth - rect.size.width;
} else {
// when we change selection to the last empty line in the editor,
// where we literally have no character there, UIKit seems to need to know
// the line's expected geometry (indent) and it derives typing attributes
// from the previous character (previous line). Happens even though we
Comment thread
hejsztynx marked this conversation as resolved.
// explicitly didn't want that in
// manageTypingAttributesWithOnlySelection:YES, so we can't trust typing
// attributes' pStyle here, manually setting the caret's position
rect.origin.x = 0;
}

return rect;
Expand Down
Loading