Skip to content

Commit 16b1a01

Browse files
authored
fix(android): drop library targetSdk for AGP 9 (#1549)
## Description - Drop library `targetSdk`: AGP 9 (RN 0.88) removed it, so `build.gradle.kts` fails to compile. It never affected the app. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [x] Android ### Testing instructions - Fresh RN 0.88.0 app: `main` fails with `Unresolved reference 'targetSdk'`; this builds and runs a text embedding model on device. ### Screenshots ### Related issues #1547 ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes
1 parent 6da666a commit 16b1a01

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

‎packages/react-native-executorch-webrtc/android/build.gradle‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ android {
3131

3232
defaultConfig {
3333
minSdkVersion 26
34-
targetSdkVersion 34
3534

3635
externalNativeBuild {
3736
cmake {

‎packages/react-native-executorch/android/build.gradle.kts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ android {
116116
// ships a library its linker is not guaranteed to be able to load. The
117117
// default was 21, which let such a build through to fail on the device.
118118
minSdk = (getExtOrDefault("minSdkVersion", 26) as Number).toInt()
119-
targetSdk = (getExtOrDefault("targetSdkVersion", 34) as Number).toInt()
120119
consumerProguardFiles("consumer-proguard-rules.pro")
121120

122121
externalNativeBuild {

0 commit comments

Comments
 (0)