review

Author: mkopcins

packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h

@@ -235,8 +235,8 @@ getValue<std::vector<std::vector<float>>>(const jsi::Value &val,
   std::vector<std::vector<float>> result;
   result.reserve(length);
   for (size_t i = 0; i < length; ++i) {
-    auto span =
-        getTypedArrayAsSpan<float>(array.getValueAtIndex(runtime, i), runtime);
+    jsi::Value element = array.getValueAtIndex(runtime, i);
+    auto span = getTypedArrayAsSpan<float>(element, runtime);
     result.emplace_back(span.begin(), span.end());
   }
   return result;

packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h

@@ -284,11 +284,9 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
         return jsi_conversion::getJsiValue(std::move(result), runtime);
       }
     } catch (const RnExecutorchError &e) {
-      rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa", e.what());
       throw jsi::JSError(runtime, makeRnExecutorchErrorValue(
                                       runtime, e.getNumericCode(), e.what()));
     } catch (const std::exception &e) {
-      rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa", e.what());
       throw jsi::JSError(runtime, e.what());
     } catch (...) {
       throw jsi::JSError(runtime, "Unknown error in synchronous function");
@@ -353,11 +351,9 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
         return jsi_conversion::getJsiValue(std::move(result), runtime);
       }
     } catch (const RnExecutorchError &e) {
-      rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa", e.what());
       throw jsi::JSError(runtime, makeRnExecutorchErrorValue(
                                       runtime, e.getNumericCode(), e.what()));
     } catch (const std::exception &e) {
-      rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa", e.what());
       throw jsi::JSError(runtime, e.what());
     } catch (...) {
       throw jsi::JSError(runtime, "Unknown error in vision function");
@@ -418,8 +414,6 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
                           });
                     }
                   } catch (const RnExecutorchError &e) {
-                    rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa",
-                                      e.what());
                     auto code = e.getNumericCode();
                     auto msg = std::string(e.what());
                     callInvoker->invokeAsync(
@@ -429,8 +423,6 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
                         });
                     return;
                   } catch (const std::exception &e) {
-                    rnexecutorch::log(rnexecutorch::LOG_LEVEL::Info, "kappa",
-                                      e.what());
                     callInvoker->invokeAsync([e = std::move(e), promise]() {
                       promise->reject(std::string(e.what()));
                     });

packages/react-native-executorch/common/runner/multimodal_prefiller.cpp

@@ -109,9 +109,9 @@ auto MultimodalPrefiller::processMultimodalInput(
     for (auto t : tokens) {
       ids.push_back(static_cast<int64_t>(t));
     }
-    ET_LOG(Error, "Unsupported MultimodalInput type");
-    return Error::NotSupported;
   }
+  ET_LOG(Error, "Unsupported MultimodalInput type");
+  return Error::NotSupported;
 }
 
 auto MultimodalPrefiller::encodeAudio(

packages/react-native-executorch/common/runner/text_prefiller.cpp

@@ -10,7 +10,6 @@
 // LLM.
 
 #include "text_prefiller.h"
-#include "rnexecutorch/Log.h"
 #include <algorithm>
 
 namespace executorch {

packages/react-native-executorch/src/hooks/natural_language_processing/useLLM.ts

@@ -59,11 +59,6 @@ export function useLLM({
       try {
         await controllerInstance.load({
           model: model,
-          // modelSource: model.modelSource,
-          // tokenizerSource: model.tokenizerSource,
-          // tokenizerConfigSource: model.tokenizerConfigSource!,
-          // capabilities: model.capabilities,
-          // defaultGenerationConfig: model.generationConfig,
           onDownloadProgressCallback: setDownloadProgress,
         });
       } catch (e) {