refactor: remove nmsConfig, avoid making breaking changes

Author: chmjkb

apps/computer-vision/app/instance_segmentation/index.tsx

@@ -112,7 +112,7 @@ export default function InstanceSegmentationScreen() {
       const start = Date.now();
       const output = await forward(imageUri, {
         confidenceThreshold: 0.5,
-        nms: { iouThreshold: 0.55 },
+        iouThreshold: 0.55,
         maxInstances: 20,
         returnMaskAtOriginalResolution: true,
         inputSize,

apps/computer-vision/app/segment_anything/index.tsx

@@ -241,7 +241,7 @@ export default function SegmentAnythingScreen() {
       const start = Date.now();
       const output = await forward(imageUri, {
         confidenceThreshold: 0.4,
-        nms: { iouThreshold: 0.9 },
+        iouThreshold: 0.9,
         maxInstances: 50,
         returnMaskAtOriginalResolution: true,
       });

apps/computer-vision/components/vision_camera/tasks/InstanceSegmentationTask.tsx

@@ -133,7 +133,7 @@ export default function InstanceSegmentationTask({
           const ih = frame.width > frame.height ? frame.width : frame.height;
           const result = instSegRof(frame, isFrontCamera, {
             confidenceThreshold: 0.5,
-            nms: { iouThreshold: 0.5 },
+            iouThreshold: 0.5,
             maxInstances: 5,
             returnMaskAtOriginalResolution: false,
             ...(activeModel === 'instanceSegmentationYolo26n' && {

packages/react-native-executorch/src/modules/computer_vision/InstanceSegmentationModule.ts

@@ -34,7 +34,7 @@ const YOLO_SEG_CONFIG = {
   availableInputSizes: [384, 512, 640] as const,
   defaultInputSize: 384,
   defaultConfidenceThreshold: 0.5,
-  defaultNms: { iouThreshold: 0.5 },
+  defaultIouThreshold: 0.5,
   postprocessorConfig: {
     applyNMS: false,
   },
@@ -46,7 +46,7 @@ const FASTSAM_CONFIG = {
   availableInputSizes: undefined,
   defaultInputSize: undefined,
   defaultConfidenceThreshold: 0.5,
-  defaultNms: { iouThreshold: 0.9 },
+  defaultIouThreshold: 0.9,
   postprocessorConfig: {
     applyNMS: true,
   },
@@ -58,7 +58,7 @@ const RF_DETR_NANO_SEG_CONFIG = {
   availableInputSizes: undefined,
   defaultInputSize: undefined, //RFDetr exposes only one method named forward
   defaultConfidenceThreshold: 0.5,
-  defaultNms: { iouThreshold: 0.5 },
+  defaultIouThreshold: 0.5,
   postprocessorConfig: {
     applyNMS: true,
   },
@@ -143,7 +143,7 @@ type ResolveLabels<T extends InstanceSegmentationModelName | LabelEnum> =
  *
  * const results = await segmentation.forward('path/to/image.jpg', {
  *   confidenceThreshold: 0.5,
- *   nms: { iouThreshold: 0.45 },
+ *   iouThreshold: 0.45,
  *   maxInstances: 20,
  *   inputSize: 640,
  * });
@@ -237,7 +237,7 @@ export class InstanceSegmentationModule<
    *     availableInputSizes: [640],
    *     defaultInputSize: 640,
    *     defaultConfidenceThreshold: 0.5,
-   *     defaultNms: { iouThreshold: 0.45 },
+   *     defaultIouThreshold: 0.45,
    *     postprocessorConfig: { applyNMS: true },
    *   },
    * );
@@ -323,10 +323,9 @@ export class InstanceSegmentationModule<
     const labelEnumOffset = this.labelEnumOffset;
     const defaultConfidenceThreshold =
       this.modelConfig.defaultConfidenceThreshold ?? 0.5;
-    const defaultNmsMode = this.modelConfig.defaultNms?.mode ?? 'greedy';
-    const defaultIouThreshold =
-      this.modelConfig.defaultNms?.iouThreshold ?? 0.5;
+    const defaultIouThreshold = this.modelConfig.defaultIouThreshold ?? 0.5;
     const defaultInputSize = this.modelConfig.defaultInputSize;
+    const useWeightedNms = this.modelConfig.nmsMode === 'weighted';
 
     return (
       frame: Frame,
@@ -337,9 +336,7 @@ export class InstanceSegmentationModule<
 
       const confidenceThreshold =
         options?.confidenceThreshold ?? defaultConfidenceThreshold;
-      const nmsMode = options?.nms?.mode ?? defaultNmsMode;
-      const iouThreshold = options?.nms?.iouThreshold ?? defaultIouThreshold;
-      const useWeightedNms = nmsMode === 'weighted';
+      const iouThreshold = options?.iouThreshold ?? defaultIouThreshold;
       const maxInstances = options?.maxInstances ?? 100;
       const returnMaskAtOriginalResolution =
         options?.returnMaskAtOriginalResolution ?? true;
@@ -386,14 +383,14 @@ export class InstanceSegmentationModule<
    * 1. **String path/URI**: File path, URL, or Base64-encoded string
    * 2. **PixelData**: Raw pixel data from image libraries (e.g., NitroImage)
    * @param input - Image source (string path or PixelData object)
-   * @param options - Optional configuration for the segmentation process. Includes `confidenceThreshold`, `nms`, `maxInstances`, `classesOfInterest`, `returnMaskAtOriginalResolution`, and `inputSize`.
+   * @param options - Optional configuration for the segmentation process. Includes `confidenceThreshold`, `iouThreshold`, `maxInstances`, `classesOfInterest`, `returnMaskAtOriginalResolution`, and `inputSize`.
    * @returns A Promise resolving to an array of {@link SegmentedInstance} objects with `bbox`, `mask`, `maskWidth`, `maskHeight`, `label`, `score`.
    * @throws {RnExecutorchError} If the model is not loaded or if an invalid `inputSize` is provided.
    * @example
    * ```ts
    * const results = await segmentation.forward('path/to/image.jpg', {
    *   confidenceThreshold: 0.6,
-   *   nms: { iouThreshold: 0.5 },
+   *   iouThreshold: 0.5,
    *   maxInstances: 10,
    *   inputSize: 640,
    *   classesOfInterest: ['PERSON', 'CAR'],
@@ -420,13 +417,9 @@ export class InstanceSegmentationModule<
       options?.confidenceThreshold ??
       this.modelConfig.defaultConfidenceThreshold ??
       0.5;
-    const nmsMode =
-      options?.nms?.mode ?? this.modelConfig.defaultNms?.mode ?? 'greedy';
     const iouThreshold =
-      options?.nms?.iouThreshold ??
-      this.modelConfig.defaultNms?.iouThreshold ??
-      0.5;
-    const useWeightedNms = nmsMode === 'weighted';
+      options?.iouThreshold ?? this.modelConfig.defaultIouThreshold ?? 0.5;
+    const useWeightedNms = this.modelConfig.nmsMode === 'weighted';
     const maxInstances = options?.maxInstances ?? 100;
     const returnMaskAtOriginalResolution =
       options?.returnMaskAtOriginalResolution ?? true;

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

@@ -35,7 +35,7 @@ const YOLO_DETECTION_CONFIG = {
   availableInputSizes: [384, 512, 640] as const,
   defaultInputSize: 384,
   defaultDetectionThreshold: 0.5,
-  defaultNms: { iouThreshold: 0.5 },
+  defaultIouThreshold: 0.5,
 } satisfies ObjectDetectionConfig<typeof CocoLabelYolo>;
 
 const ModelConfigs = {
@@ -45,15 +45,15 @@ const ModelConfigs = {
     availableInputSizes: undefined,
     defaultInputSize: undefined,
     defaultDetectionThreshold: 0.7,
-    defaultNms: { iouThreshold: 0.55 },
+    defaultIouThreshold: 0.55,
   },
   'rf-detr-nano': {
     labelMap: CocoLabel,
     preprocessorConfig: { normMean: IMAGENET1K_MEAN, normStd: IMAGENET1K_STD },
     availableInputSizes: undefined,
     defaultInputSize: undefined,
     defaultDetectionThreshold: 0.7,
-    defaultNms: { iouThreshold: 0.55 },
+    defaultIouThreshold: 0.55,
   },
   'yolo26n': YOLO_DETECTION_CONFIG,
   'yolo26s': YOLO_DETECTION_CONFIG,
@@ -66,8 +66,9 @@ const ModelConfigs = {
     availableInputSizes: undefined,
     defaultInputSize: undefined,
     defaultDetectionThreshold: 0.5,
-    defaultNms: { mode: 'weighted', iouThreshold: 0.3 },
-    defaultUseLetterbox: true,
+    defaultIouThreshold: 0.3,
+    nmsMode: 'weighted',
+    useLetterbox: true,
   },
 } as const satisfies Record<
   ObjectDetectionModelName,
@@ -182,12 +183,11 @@ export class ObjectDetectionModule<
 
     const defaultDetectionThreshold =
       this.modelConfig.defaultDetectionThreshold ?? 0.7;
-    const defaultNmsMode = this.modelConfig.defaultNms?.mode ?? 'greedy';
-    const defaultIouThreshold =
-      this.modelConfig.defaultNms?.iouThreshold ?? 0.55;
+    const defaultIouThreshold = this.modelConfig.defaultIouThreshold ?? 0.55;
     const defaultInputSize = this.modelConfig.defaultInputSize;
     const availableInputSizes = this.modelConfig.availableInputSizes;
-    const defaultUseLetterbox = this.modelConfig.defaultUseLetterbox ?? false;
+    const useWeightedNms = this.modelConfig.nmsMode === 'weighted';
+    const useLetterbox = this.modelConfig.useLetterbox ?? false;
 
     return (
       frame: any,
@@ -198,11 +198,8 @@ export class ObjectDetectionModule<
 
       const detectionThreshold =
         options?.detectionThreshold ?? defaultDetectionThreshold;
-      const nmsMode = options?.nms?.mode ?? defaultNmsMode;
-      const iouThreshold = options?.nms?.iouThreshold ?? defaultIouThreshold;
+      const iouThreshold = options?.iouThreshold ?? defaultIouThreshold;
       const inputSize = options?.inputSize ?? defaultInputSize;
-      const useWeightedNms = nmsMode === 'weighted';
-      const useLetterbox = options?.useLetterbox ?? defaultUseLetterbox;
 
       if (
         availableInputSizes &&
@@ -272,16 +269,11 @@ export class ObjectDetectionModule<
       options?.detectionThreshold ??
       this.modelConfig.defaultDetectionThreshold ??
       0.7;
-    const nmsMode =
-      options?.nms?.mode ?? this.modelConfig.defaultNms?.mode ?? 'greedy';
     const iouThreshold =
-      options?.nms?.iouThreshold ??
-      this.modelConfig.defaultNms?.iouThreshold ??
-      0.55;
+      options?.iouThreshold ?? this.modelConfig.defaultIouThreshold ?? 0.55;
     const inputSize = options?.inputSize ?? this.modelConfig.defaultInputSize;
-    const useWeightedNms = nmsMode === 'weighted';
-    const useLetterbox =
-      options?.useLetterbox ?? this.modelConfig.defaultUseLetterbox ?? false;
+    const useWeightedNms = this.modelConfig.nmsMode === 'weighted';
+    const useLetterbox = this.modelConfig.useLetterbox ?? false;
 
     // Validate inputSize against availableInputSizes
     if (

packages/react-native-executorch/src/types/common.ts

@@ -146,28 +146,6 @@ export type LabelEnum = Readonly<Record<string, number | string>>;
  */
 export type Triple<T> = readonly [T, T, T];
 
-/**
- * Non-maximum suppression configuration shared by computer-vision models that
- * deduplicate overlapping detections (object detection, instance segmentation).
- *
- * - `'greedy'` (default): standard NMS — keep the highest-scoring box, drop
- *   anything overlapping it above {@link iouThreshold}. Suits detectors like
- *   YOLO / SSDLite whose individual anchors are trained to be accurate
- *   standalone.
- * - `'weighted'`: score-weighted blending — average overlapping boxes by
- *   their scores instead of pruning to a single winner. Required for
- *   detectors like BlazeFace whose anchors were trained as an ensemble.
- *
- * Both fields are optional in per-call options and the model preset's
- * `defaultNms`; missing fields fall back through the preset default to the
- * runtime default.
- * @category Types
- */
-export interface NmsConfig {
-  mode?: 'greedy' | 'weighted';
-  /** IoU threshold (0-1). Boxes overlapping above this are suppressed (greedy) or merged (weighted). */
-  iouThreshold?: number;
-}
 /**
  * Represents raw pixel data in RGB format for vision models.
  *

packages/react-native-executorch/src/types/instanceSegmentation.ts

@@ -1,12 +1,5 @@
 import { RnExecutorchError } from '../errors/errorUtils';
-import {
-  LabelEnum,
-  NmsConfig,
-  ResourceSource,
-  Triple,
-  Frame,
-  PixelData,
-} from './common';
+import { LabelEnum, ResourceSource, Triple, Frame, PixelData } from './common';
 import { Bbox } from './objectDetection';
 
 /**
@@ -55,12 +48,12 @@ export interface InstanceSegmentationOptions<L extends LabelEnum> {
    */
   confidenceThreshold?: number;
   /**
-   * Override NMS mode and/or `iouThreshold` for this call. Partial — missing
-   * fields fall back to the model preset's `defaultNms`. Ignored for models
-   * whose preset disables external NMS (`postprocessorConfig.applyNMS: false`,
-   * e.g. YOLO-seg which does NMS internally).
+   * IoU threshold for non-maximum suppression (0-1). Defaults to the model
+   * preset's `defaultIouThreshold`. Ignored for models whose preset disables
+   * external NMS (`postprocessorConfig.applyNMS: false`, e.g. YOLO-seg which
+   * does NMS internally).
    */
-  nms?: NmsConfig;
+  iouThreshold?: number;
   /**
    * Maximum number of instances to return. Default: 100
    */
@@ -106,11 +99,17 @@ export type InstanceSegmentationConfig<T extends LabelEnum> = {
   postprocessorConfig?: { applyNMS?: boolean };
   defaultConfidenceThreshold?: number;
   /**
-   * Default NMS configuration. Overridable per-call via
-   * {@link InstanceSegmentationOptions.nms}. Has no effect when
+   * Default IoU threshold for non-maximum suppression (0-1). Overridable per-call
+   * via {@link InstanceSegmentationOptions.iouThreshold}. Has no effect when
    * `postprocessorConfig.applyNMS` is `false`.
    */
-  defaultNms?: NmsConfig;
+  defaultIouThreshold?: number;
+  /**
+   * NMS algorithm baked into the model preset. Architectural — not per-call tuneable.
+   * - `'greedy'` (default): standard NMS, suits detectors whose anchors are independently accurate.
+   * - `'weighted'`: score-weighted box blending, required for ensemble-trained detectors.
+   */
+  nmsMode?: 'greedy' | 'weighted';
 } & (
   | {
       availableInputSizes: readonly number[];

packages/react-native-executorch/src/types/objectDetection.ts

@@ -1,12 +1,5 @@
 import { RnExecutorchError } from '../errors/errorUtils';
-import {
-  LabelEnum,
-  NmsConfig,
-  Triple,
-  ResourceSource,
-  PixelData,
-  Frame,
-} from './common';
+import { LabelEnum, Triple, ResourceSource, PixelData, Frame } from './common';
 import { CocoLabel } from '../constants/commonVision';
 export { CocoLabel };
 
@@ -47,20 +40,12 @@ export interface Detection<L extends LabelEnum = typeof CocoLabel> {
 export interface ObjectDetectionOptions<L extends LabelEnum> {
   /** Minimum confidence score for detections (0-1). Defaults to the model preset's value. */
   detectionThreshold?: number;
-  /** Override NMS mode and/or `iouThreshold` for this call. Partial — missing fields fall back to the model preset's `defaultNms`. */
-  nms?: NmsConfig;
+  /** IoU threshold for non-maximum suppression (0-1). Defaults to the model preset's `defaultIouThreshold`. */
+  iouThreshold?: number;
   /** Input size for multi-method models (e.g. 384/512/640 for YOLO). */
   inputSize?: number;
   /** Restrict output to these class labels. */
   classesOfInterest?: (keyof L)[];
-  /**
-   * If true, preprocess by aspect-preserving fit + center-pad (letterbox)
-   * instead of a plain stretch resize to the model's input size. Required
-   * for models trained on natural-aspect crops (e.g. BlazeFace) — a stretched
-   * portrait frame shifts anchor positions and predicts a too-narrow box.
-   * Defaults to the model preset's `defaultUseLetterbox`.
-   */
-  useLetterbox?: boolean;
 }
 
 /**
@@ -96,10 +81,20 @@ export type ObjectDetectionConfig<T extends LabelEnum> = {
   preprocessorConfig?: { normMean?: Triple<number>; normStd?: Triple<number> };
   /** Default detection confidence threshold (0-1). */
   defaultDetectionThreshold?: number;
-  /** Default NMS configuration. Overridable per-call via {@link ObjectDetectionOptions.nms}. */
-  defaultNms?: NmsConfig;
-  /** Default preprocessing for this model. Overridable per-call via `useLetterbox`. */
-  defaultUseLetterbox?: boolean;
+  /** Default IoU threshold for non-maximum suppression (0-1). Overridable per-call via {@link ObjectDetectionOptions.iouThreshold}. */
+  defaultIouThreshold?: number;
+  /**
+   * NMS algorithm baked into the model preset. Architectural — not per-call tuneable.
+   * - `'greedy'` (default): standard NMS, suits detectors whose anchors are independently accurate (YOLO, SSDLite, RF-DETR).
+   * - `'weighted'`: score-weighted box blending, required for ensemble-trained detectors like BlazeFace.
+   */
+  nmsMode?: 'greedy' | 'weighted';
+  /**
+   * Whether the model expects aspect-preserving fit + center-pad (letterbox) preprocessing
+   * instead of plain stretch resize. Architectural property of the model — not per-call tuneable.
+   * BlazeFace requires letterbox; YOLO/SSDLite/RF-DETR do not.
+   */
+  useLetterbox?: boolean;
 } & (
   | {
       availableInputSizes: readonly number[];