Skip to content

Commit 9f3bbd8

Browse files
authored
chore(legacy)!: remove legacy API support and WebRTC (#1589)
## Description Removes the legacy API, example apps, resource fetcher packages, WebRTC package, and legacy documentation. Cleans up native bindings, build configuration, publishing workflows, dependencies, and tests. ### Introduces a breaking change? - [x] Yes - [ ] No ### Type of change - [ ] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [x] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions - [x] Clean-build the computer vision, NLP, and speech example apps on Android and iOS. - [x] Launch each app and confirm native initialization succeeds. - [ ] Confirm archived versioned documentation is correct. ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues Closes #1421 ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
1 parent 2e4cf78 commit 9f3bbd8

617 files changed

Lines changed: 188 additions & 100410 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.eslintrc.js‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,6 @@ module.exports = {
7373
'no-console': 'warn',
7474
},
7575
},
76-
{
77-
// ==============================================================================
78-
// LEGACY SUPPORT: disable v0.10 lint rules for legacy code (remove when legacy is dropped)
79-
// ==============================================================================
80-
files: [
81-
'packages/react-native-executorch/legacy/**/*.{js,jsx,ts,tsx}',
82-
'packages/bare-resource-fetcher/**/*.{js,jsx,ts,tsx}',
83-
'packages/expo-resource-fetcher/**/*.{js,jsx,ts,tsx}',
84-
],
85-
rules: {
86-
'jsdoc/match-description': 'off',
87-
'camelcase': 'off',
88-
'eslint-comments/no-unused-disable': 'off',
89-
},
90-
},
9176
{
9277
// The JSDoc rules exist to keep the generated API reference complete.
9378
// Test helpers are not part of that surface, and requiring a tag per

‎.gitattributes‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22
# specific for windows script files
33
*.bat text eol=crlf
44

5-
# Exclude apps, third-party, and legacy code from language stats & line counts
5+
# Exclude apps and third-party code from language stats & line counts
66
apps/** linguist-vendored
77
third-party/** linguist-vendored
88
**/third-party/** linguist-vendored
9-
**/legacy/** linguist-vendored
109

1110
# Exclude documentation from codebase language stats
1211
docs/** linguist-documentation

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ jobs:
7070

7171
# eslint, tsc and jest read none of the C++ trees, and none of the
7272
# documentation.
73-
ts_irrelevant='^(docs/|[^/]+\.md$|packages/react-native-executorch/(cpp|legacy/cpp)/)'
73+
ts_irrelevant='^(docs/|[^/]+\.md$|packages/react-native-executorch/cpp/)'
7474
if echo "$files" | grep -qvE "$ts_irrelevant"; then ts=true; else ts=false; fi
7575

7676
# The C++ suite compiles cpp/ only (cpp/tests/CMakeLists.txt globs
77-
# core/ and extensions/, never legacy/). The rest of this list is what
77+
# core/ and extensions/). The rest of this list is what
7878
# decides which ExecuTorch release it builds and links against:
7979
# package.json carries nativeLibsVersion, which download-libs.js reads
8080
# to pick the headers release, and the CI job cross-checks that
@@ -147,7 +147,7 @@ jobs:
147147
run: yarn lint
148148

149149
- name: Typecheck files
150-
run: yarn workspaces foreach --all --exclude react-native-executorch-webrtc --topological-dev run prepare && yarn typecheck
150+
run: yarn workspaces foreach --all --topological-dev run prepare && yarn typecheck
151151

152152
build-library:
153153
needs: changes
@@ -161,7 +161,7 @@ jobs:
161161
uses: ./.github/actions/setup
162162

163163
- name: Build all packages
164-
run: yarn workspaces foreach --all --exclude react-native-executorch-webrtc --topological-dev run prepare
164+
run: yarn workspaces foreach --all --topological-dev run prepare
165165

166166
native-tests:
167167
name: C++ unit tests

‎.github/workflows/npm-publish-satellites.yml‎

Lines changed: 0 additions & 140 deletions
This file was deleted.

‎.github/workflows/npm-publish.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
if: ${{ env.EXECUTORCH_VERSION == 'PLACEHOLDER' }}
7979
run: exit 1 # this should never happen
8080

81-
# The root workspaces glob is packages/* + apps/* + apps/legacy/*, so a
81+
# The root workspaces glob is packages/* + apps/*, so a
8282
# plain `yarn install` pulled 1659 packages (597 MiB) to build one of
8383
# them: 164s of a 197s job, against 19s for the actual build. `workspaces
8484
# focus` installs only this package's tree; it is built into Yarn 4, the

‎.gitignore‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,6 @@ ios/generated
9292
android/generated
9393
apps/*/ios/
9494
apps/*/android/
95-
# === LEGACY SUPPORT: Expo prebuild directories for legacy apps (remove when legacy apps are dropped) ===
96-
apps/legacy/*/ios/
97-
apps/legacy/*/android/
98-
!apps/legacy/bare-rn/ios/
99-
!apps/legacy/bare-rn/android/
10095
**/Pods/
10196

10297
# generated TypeDoc API reference (regenerated at build time)

0 commit comments

Comments
 (0)