Repository navigation
fix: make native error of type Error instead of Object - #1165
Merged
Merged
Conversation
msluszniak
approved these changes
May 21, 2026
msluszniak
left a comment
msluszniak
left a comment
Member
There was a problem hiding this comment.
Tested on this coreml failing model and now the error has shown clearly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1150
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Check if the faulty example of CoreML multilingual embedding model displays proper error message, also verity that error.code and error.message are present. Make sure that
e instanceof Erroris true.Screenshots
Related issues
Checklist
Additional notes