Skip to content

Commit 0564cd2

Browse files
committed
[CI] Read the Node version from .nvmrc
## Description Every workflow hardcoded its own `node-version`, so the version lived in 14 places and drifted. `macos-build` was still on 22 because #3753 bumped only the `setup-node` action version in that file, and `yarn-validation` had no pin at all and ran whatever Node the runner happens to ship. Both cases were invisible until you grepped for them. All 14 workflows that set up Node now read `node-version-file: '.nvmrc'`, which holds `24.19`, so bumping Node is a one-line change. ## Test plan Checks should pass
1 parent e26231e commit 0564cd2

15 files changed

Lines changed: 29 additions & 26 deletions

‎.github/workflows/android-build.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ jobs:
3232
distribution: oracle
3333
java-version: 17
3434

35-
- name: Use Node.js 24
35+
- name: Use Node.js
3636
uses: actions/setup-node@v6
3737
with:
38-
node-version: 24
38+
node-version-file: '.nvmrc'
3939
cache: yarn
4040

4141
- name: Install node dependencies

‎.github/workflows/android-e2e.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ jobs:
3737
distribution: oracle
3838
java-version: 17
3939

40-
- name: Use Node.js 24
40+
- name: Use Node.js
4141
uses: actions/setup-node@v6
4242
with:
43-
node-version: 24
43+
node-version-file: '.nvmrc'
4444

4545
- name: Download APK built by the build workflow
4646
uses: actions/download-artifact@v4

‎.github/workflows/docs-check.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
- name: checkout
2222
uses: actions/checkout@v4
2323

24-
- name: Use Node.js 24
24+
- name: Use Node.js
2525
uses: actions/setup-node@v6
2626
with:
27-
node-version: 24
27+
node-version-file: '.nvmrc'
2828

2929
- name: Install node dependencies
3030
working-directory: ${{ env.WORKING_DIRECTORY }}

‎.github/workflows/ios-build.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ jobs:
4545
echo "DEVELOPER_DIR=$XCODE_APP/Contents/Developer" >> "$GITHUB_ENV"
4646
DEVELOPER_DIR="$XCODE_APP/Contents/Developer" xcodebuild -version
4747
48-
- name: Use Node.js 24
48+
- name: Use Node.js
4949
uses: actions/setup-node@v6
5050
with:
51-
node-version: 24
51+
node-version-file: '.nvmrc'
5252
cache: yarn
5353

5454
- name: Install node dependencies

‎.github/workflows/ios-e2e.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ jobs:
3939
DEVELOPER_DIR="$XCODE_APP/Contents/Developer" xcodebuild -version
4040
4141
# Only needed to run the Argent CLI — the app is downloaded, not built.
42-
- name: Use Node.js 24
42+
- name: Use Node.js
4343
uses: actions/setup-node@v6
4444
with:
45-
node-version: 24
45+
node-version-file: '.nvmrc'
4646

4747
- name: Download app built by the build workflow
4848
uses: actions/download-artifact@v4

‎.github/workflows/ios-spm-build-test.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ jobs:
5555
echo "DEVELOPER_DIR=$XCODE_APP/Contents/Developer" >> "$GITHUB_ENV"
5656
DEVELOPER_DIR="$XCODE_APP/Contents/Developer" xcodebuild -version
5757
58-
- name: Use Node.js 24
58+
- name: Use Node.js
5959
uses: actions/setup-node@v6
6060
with:
61-
node-version: 24
61+
node-version-file: '.nvmrc'
6262
cache: yarn
6363

6464
- name: Read React Native version

‎.github/workflows/kotlin-lint.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ jobs:
3030
distribution: oracle
3131
java-version: 17
3232

33-
- name: Use Node.js 24
33+
- name: Use Node.js
3434
uses: actions/setup-node@v6
3535
with:
36-
node-version: 24
36+
node-version-file: '.nvmrc'
3737
cache: yarn
3838

3939
- uses: actions/cache@v4

‎.github/workflows/macos-build.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
- name: checkout
2828
uses: actions/checkout@v4
2929

30-
- name: Use Node.js 22
30+
- name: Use Node.js
3131
uses: actions/setup-node@v6
3232
with:
33-
node-version: 22
33+
node-version-file: '.nvmrc'
3434
cache: yarn
3535

3636
- name: Install node dependencies

‎.github/workflows/publish-release.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ jobs:
4747
run: |
4848
echo "YARN_ENABLE_HARDENED_MODE=0" >> $GITHUB_ENV
4949
50-
- name: Setup Node
50+
- name: Use Node.js
5151
uses: actions/setup-node@v6
5252
with:
53-
node-version: 24
53+
node-version-file: '.nvmrc'
5454
cache: 'yarn'
5555
registry-url: https://registry.npmjs.org/
5656

‎.github/workflows/rngh-api-v3.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
- name: checkout
2525
uses: actions/checkout@v4
2626

27-
- name: Use Node.js 24
27+
- name: Use Node.js
2828
uses: actions/setup-node@v6
2929
with:
30-
node-version: 24
30+
node-version-file: '.nvmrc'
3131
cache: yarn
3232

3333
- name: Install node dependencies

0 commit comments

Comments
 (0)