Skip to content

Commit 35a0aea

Browse files
authored
[Android] Fix basic-example hermesc path (#4371)
## Description I've noticed that release builds of basic example fail on android due to the wrong path of hermesc set. `hermesc` path is resolved with the working dir set to the app directory and React Native will automatically select the right [OS-specific path](https://github.com/react/react-native/blob/63e9c1544834a43b1b44af4033184b1eab6f2ffa/packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PathUtils.kt#L137-L139). ## Test plan Build the app in release mode or run `./gradlew :app:createBundleReleaseJsAndAssets` before & after this change.
1 parent f0c98c7 commit 35a0aea

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎apps/basic-example/android/app/build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ react {
6060

6161
/* Hermes Commands */
6262
// The hermes compiler command to run. By default it is 'hermesc'
63-
hermesCommand = "../../../../node_modules/react-native/sdks/hermesc/osx-bin/hermesc"
63+
hermesCommand = "../../node_modules/hermes-compiler/hermesc/%OS-BIN%/hermesc"
6464
//
6565
// The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map"
6666
// hermesFlags = ["-O", "-output-source-map"]

0 commit comments

Comments
 (0)