Skip to content

Commit 9fdf835

Browse files
committed
[Example] Keep "Basic" in example names, add test ids
## Description "Basic" examples were missing the "Basic" in their labels, making it harder to describe specific examples to e2e tests. Console interaction buttons were missing test ids. ## Test plan Check Expo example
1 parent 3e4497e commit 9fdf835

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

‎apps/common-app/src/console/ConsoleModal.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ function ConsoleModalContent({ entries, visible, onClose }: ConsoleModalProps) {
236236
</View>
237237
<View style={styles.modalActions}>
238238
<Touchable
239+
testID="clear-console-button"
239240
accessibilityRole="button"
240241
disabled={entries.length === 0}
241242
activeOpacity={0.5}
@@ -250,6 +251,7 @@ function ConsoleModalContent({ entries, visible, onClose }: ConsoleModalProps) {
250251
</Text>
251252
</Touchable>
252253
<Touchable
254+
testID="close-console-button"
253255
accessibilityRole="button"
254256
accessibilityLabel="Close console"
255257
activeOpacity={0.5}

‎apps/common-app/src/new_api/index.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ export const NEW_EXAMPLES: ExamplesSection[] = [
5454
{
5555
sectionTitle: 'Simple Gestures',
5656
data: [
57-
{ name: 'Fling', component: FlingExample },
58-
{ name: 'Tap', component: TapExample },
59-
{ name: 'LongPress', component: LongPressExample },
60-
{ name: 'Hover', component: HoverExample },
61-
{ name: 'Pinch', component: PinchExample },
62-
{ name: 'Rotation', component: RotationExample },
63-
{ name: 'Pan', component: PanExample },
57+
{ name: 'Basic Fling', component: FlingExample },
58+
{ name: 'Basic Tap', component: TapExample },
59+
{ name: 'Basic LongPress', component: LongPressExample },
60+
{ name: 'Basic Hover', component: HoverExample },
61+
{ name: 'Basic Pinch', component: PinchExample },
62+
{ name: 'Basic Rotation', component: RotationExample },
63+
{ name: 'Basic Pan', component: PanExample },
6464
],
6565
},
6666
{

0 commit comments

Comments
 (0)