Expose the module id through a sync TurboModule method instead of a JSI global (#4525)

## Description

`GestureHandlerRootView`, `Touchable`, `NativeDetector` and
`InterceptingGestureDetector` read `globalThis._RNGH_MODULE_ID` to pass
the module id to their native views. The global is written by the
module's JSI bindings installer, which RN runs only when the
`TurboModule` is first accessed, and nothing in the library accessed it
on purpose before the root view rendered. With the default Metro config
it happened to work because evaluating the package index eagerly walks
`legacy_createNativeWrapper` → `NativeViewGestureHandler` →
`createHandler` → `RNGestureHandlerModule`, which instantiates the
module. Anything that skips that chain (the deep import from the issue,
a bundler that lowers default imports lazily, removing the v1 re-export)
leaves the global undefined, the native view gets the codegen default
`-1`, and `RNGestureHandlerRootHelper` throws "Tried to access a
non-existent registry" on mount. Debug builds never show it because
React Refresh enumerates every export of the index after it loads, which
fires the lazy getters and instantiates the module anyway.

The id is now a sync method on the module, `getModuleId`, read through a
cached `getModuleId()` helper. Asking the module for the id guarantees
the module is instantiated first, independently of bundle evaluation
order. The JSI global, `globals.ts` and the JNI field lookup are
removed. Web, Windows and the Jest mock return `-1`. The registry error
message on Android now includes the module id.

Also drops an unused `#include <string>` from the Android JNI module
header.

Fixes #4523

## Test plan

- basic-example on Android (debug) with the deep import from the issue:
crashed before, renders now.
- basic-example on Android (release) with the normal import and the
`legacy_createNativeWrapper` re-export commented out: crashed before,
renders now.
- basic-example on iOS and the Empty example on web: `Touchable`, tap
and pan detectors and `Pressable` respond
- `yarn ts-check`, `yarn lint:js`, `yarn test`.

<details>
<summary>Tested on the following code:</summary>

```tsx
// Repro for #4523 (same screen as apps/basic-example/src/Repro4523Content.tsx).
// The root view is deep-imported so nothing but the root view itself can
// instantiate the native module before it mounts. On web it is a plain View
// and the module id is -1.
import React from 'react';
import { StyleSheet, Text, View } from 'react-native';
import {
  GestureDetector,
  Pressable,
  Touchable,
  usePanGesture,
  useTapGesture,
} from 'react-native-gesture-handler';
import GestureHandlerRootView from 'react-native-gesture-handler/src/components/GestureHandlerRootView';
import { getModuleId } from 'react-native-gesture-handler/src/moduleId';

export default function EmptyExample() {
  return (
    <GestureHandlerRootView style={styles.container}>
      <Repro4523Content />
    </GestureHandlerRootView>
  );
}

function Repro4523Content() {
  const [touches, setTouches] = React.useState(0);
  const [taps, setTaps] = React.useState(0);
  const [presses, setPresses] = React.useState(0);
  const [pan, setPan] = React.useState({ x: 0, y: 0 });

  const tap = useTapGesture({
    runOnJS: true,
    onActivate: () => setTaps((t) => t + 1),
  });
  const panGesture = usePanGesture({
    runOnJS: true,
    onUpdate: (e) =>
      setPan({ x: Math.round(e.translationX), y: Math.round(e.translationY) }),
  });

  return (
    <View style={styles.content}>
      <Text style={styles.title}>#4523 repro</Text>
      <Text>module id: {getModuleId()} (increments on reload)</Text>

      <Touchable
        style={[styles.box, { backgroundColor: '#8e44ad' }]}
        onPress={() => setTouches((t) => t + 1)}>
        <Text style={styles.label}>touchable: {touches}</Text>
      </Touchable>

      <GestureDetector gesture={tap}>
        <View style={[styles.box, { backgroundColor: '#4a90d9' }]}>
          <Text style={styles.label}>tap: {taps}</Text>
        </View>
      </GestureDetector>

      <GestureDetector gesture={panGesture}>
        <View style={[styles.box, { backgroundColor: '#50b86c' }]}>
          <Text style={styles.label}>
            pan: {pan.x}, {pan.y}
          </Text>
        </View>
      </GestureDetector>

      <Pressable
        style={({ pressed }) => [
          styles.box,
          { backgroundColor: pressed ? '#b03a2e' : '#e74c3c' },
        ]}
        onPress={() => setPresses((p) => p + 1)}>
        <Text style={styles.label}>pressable: {presses}</Text>
      </Pressable>
    </View>
  );
}

const styles = StyleSheet.create({
  container: { flex: 1 },
  content: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
    gap: 16,
  },
  title: { fontSize: 20, fontWeight: 'bold' },
  box: {
    width: 220,
    height: 80,
    borderRadius: 12,
    alignItems: 'center',
    justifyContent: 'center',
  },
  label: { color: 'white', fontSize: 16 },
});
```
</details>

Author: m-bert

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerModule.kt

@@ -170,6 +170,9 @@ class RNGestureHandlerModule(reactContext: ReactApplicationContext?) :
 
   override fun getBindingsInstaller() = getBindingsInstallerCxx()
 
+  @ReactMethod(isBlockingSynchronousMethod = true)
+  override fun getModuleId(): Double = moduleId.toDouble()
+
   override fun invalidate() {
     registry.dropAllHandlers()
     interactionManager.reset()

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt

@@ -27,7 +27,8 @@ class RNGestureHandlerRootHelper(private val context: ReactContext, wrappedView:
 
   init {
     val registry =
-      RNGestureHandlerModule.registries[moduleId] ?: throw Exception("Tried to access a non-existent registry")
+      RNGestureHandlerModule.registries[moduleId]
+        ?: throw Exception("Tried to access a non-existent registry for module $moduleId")
 
     UiThreadUtil.assertOnUiThread()
     val wrappedViewTag = wrappedView.id
@@ -65,7 +66,8 @@ class RNGestureHandlerRootHelper(private val context: ReactContext, wrappedView:
 
   fun tearDown() {
     val registry =
-      RNGestureHandlerModule.registries[moduleId] ?: throw Exception("Tried to access a non-existent registry")
+      RNGestureHandlerModule.registries[moduleId]
+        ?: throw Exception("Tried to access a non-existent registry for module $moduleId")
 
     Log.i(
       ReactConstants.TAG,

packages/react-native-gesture-handler/android/src/main/jni/RNGestureHandlerModule.cpp

@@ -37,7 +37,7 @@ RNGestureHandlerModule::getBindingsInstallerCxx() {
       [&, this](jsi::Runtime &runtime) {
         this->rnRuntime_ = &runtime;
         RNGHRuntimeDecorator::installRNRuntimeBindings(
-            runtime, getModuleId(), [&](int handlerTag, int state) {
+            runtime, [&](int handlerTag, int state) {
               setGestureState(handlerTag, state);
             });
       }));
@@ -73,14 +73,4 @@ void RNGestureHandlerModule::invalidateNative() {
   javaPart_ = nullptr;
 }
 
-int RNGestureHandlerModule::getModuleId() {
-  auto jthis = javaPart_;
-
-  auto cls = jthis->getClass();
-  auto fieldId = cls->getField<jint>("moduleId");
-
-  jint value = jthis->getFieldValue(fieldId);
-  return value;
-}
-
 } // namespace gesturehandler

packages/react-native-gesture-handler/android/src/main/jni/RNGestureHandlerModule.h

@@ -1,7 +1,6 @@
 #pragma once
 #include <ReactCommon/BindingsInstallerHolder.h>
 #include <fbjni/fbjni.h>
-#include <string>
 
 namespace gesturehandler {
 using namespace facebook;
@@ -29,6 +28,5 @@ class RNGestureHandlerModule : public jni::HybridClass<RNGestureHandlerModule> {
   void setGestureState(const int handlerTag, const int state);
   bool installUIRuntimeBindings();
   void invalidateNative();
-  int getModuleId();
 };
 } // namespace gesturehandler

packages/react-native-gesture-handler/apple/RNGestureHandlerModule.mm

@@ -98,7 +98,7 @@ - (void)installJSIBindingsWithRuntime:(jsi::Runtime &)rnRuntime
   _rnRuntime = &rnRuntime;
   __weak RNGestureHandlerModule *weakSelf = self;
 
-  RNGHRuntimeDecorator::installRNRuntimeBindings(rnRuntime, _moduleId, [weakSelf](int handlerTag, int state) {
+  RNGHRuntimeDecorator::installRNRuntimeBindings(rnRuntime, [weakSelf](int handlerTag, int state) {
     RNGestureHandlerModule *strongSelf = weakSelf;
     if (strongSelf != nil) {
       [strongSelf setGestureState:state forHandler:handlerTag];
@@ -209,6 +209,11 @@ - (nonnull NSNumber *)installUIRuntimeBindings
   return _uiRuntimeDecorated ? @1 : @0;
 }
 
+- (nonnull NSNumber *)getModuleId
+{
+  return @(_moduleId);
+}
+
 - (void)setGestureState:(int)state forHandler:(int)handlerTag
 {
   if (RCTIsMainQueue()) {

packages/react-native-gesture-handler/shared/runtime/RNGHRuntimeDecorator.cpp

@@ -18,7 +18,6 @@ using namespace facebook::react;
 
 void RNGHRuntimeDecorator::installRNRuntimeBindings(
     jsi::Runtime &rnRuntime,
-    int moduleId,
     std::function<void(int, int)> &&setGestureState) {
   const auto isViewFlatteningDisabled = jsi::Function::createFromHostFunction(
       rnRuntime,
@@ -83,10 +82,6 @@ void RNGHRuntimeDecorator::installRNRuntimeBindings(
 
   rnRuntime.global().setProperty(
       rnRuntime, "_setGestureStateAsync", std::move(setGestureStateAsync));
-
-  auto moduleIdValue = jsi::Value(moduleId);
-  rnRuntime.global().setProperty(
-      rnRuntime, "_RNGH_MODULE_ID", std::move(moduleIdValue));
 }
 
 void RNGHRuntimeDecorator::installUIRuntimeBindings(

packages/react-native-gesture-handler/shared/runtime/RNGHRuntimeDecorator.h

@@ -17,7 +17,6 @@ class RNGHRuntimeDecorator {
  public:
   static void installRNRuntimeBindings(
       jsi::Runtime &rnRuntime,
-      int moduleId,
       std::function<void(int, int)> &&setGestureState);
   static void installUIRuntimeBindings(
       jsi::Runtime &uiRuntime,

packages/react-native-gesture-handler/src/RNGestureHandlerModule.web.ts

@@ -102,4 +102,7 @@ export default {
     // No-op on web
     return true;
   },
+  getModuleId() {
+    return -1;
+  },
 };

packages/react-native-gesture-handler/src/RNGestureHandlerModule.windows.ts

@@ -47,4 +47,7 @@ export default {
   flushOperations() {
     // NO-OP
   },
+  getModuleId() {
+    return -1;
+  },
 };

packages/react-native-gesture-handler/src/components/GestureHandlerRootView.android.tsx

@@ -3,6 +3,7 @@ import * as React from 'react';
 import { StyleSheet } from 'react-native';
 
 import GestureHandlerRootViewContext from '../GestureHandlerRootViewContext';
+import { getModuleId } from '../moduleId';
 import type { RootViewNativeProps } from '../specs/RNGestureHandlerRootViewNativeComponent';
 import GestureHandlerRootViewNativeComponent from '../specs/RNGestureHandlerRootViewNativeComponent';
 
@@ -18,7 +19,7 @@ export default function GestureHandlerRootView({
       <GestureHandlerRootViewNativeComponent
         style={style ?? styles.container}
         {...rest}
-        moduleId={globalThis._RNGH_MODULE_ID} // Ensure moduleId is set
+        moduleId={getModuleId()}
       />
     </GestureHandlerRootViewContext>
   );