Repository navigation
[Types] Remove onUpdate from discrete gestures - #3811
Merged
Merged
Conversation
m-bert
reviewed
Nov 12, 2025
| FlingGestureProperties | ||
| >; | ||
|
|
||
| export function useFling(config: FlingGestureConfig): FlingGesture { |
Collaborator
There was a problem hiding this comment.
Is specifying return type necessary?
Member
Author
There was a problem hiding this comment.
Without it, the type is inferred from useGesture, which doesn't know what kind of gesture it creates, so all are typed the same as continuous gestures. Another benefit is that gestures are now using named types.
m-bert
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discrete gestures shouldn't be sending
updateevents, so theonUpdatemethod shouldn't be accepted by the type definitions.It also moves the type definitions for events and gestures above the hook definition. I'm pretty sure it was also correct before, but I think it's cleaner when things are declared before they are used. LMK what you think.
Test plan