Repository navigation
Apply more granular memoization - #3815
Merged
Merged
Conversation
m-bert
reviewed
Nov 13, 2025
| ) { | ||
| return useMemo(() => { | ||
| const handlers = extractStateChangeHandlers(config); | ||
| const handlers = ensureStateChangeHandlers({ |
Collaborator
There was a problem hiding this comment.
I'm not sure if ensure is the correct prefix here. As far as I remember @akwasniewski used it to mark required variables and we decided to throws errors if those are undefined. In that case it is perfectly fine that some of them are undefined.
Contributor
There was a problem hiding this comment.
Yeah, i used it in this way, thus I don't think the rename is fitting. It might be better to leave the old extract, or use something like prepare
j-piasecki
added a commit
that referenced
this pull request
Nov 14, 2025
## Description Currently config is cloned and modified on every render in gesture hooks. This PR changes that, so that it's memoized assuming the input is also stable. ## Test plan Verify that if the input config is memoized, the returned gesture reference is stable as long as the config doesn't change (will require other PRs to be merged first). - #3815 - #3812
m-bert
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hooks and utils for creating event handlers and gesture relations were always relying on the entire config, while they require only a subset of its fields. This PR changes those to only work with what they actually need and updates the dependency arrays.
Test plan
Verify that created handlers are stable between renders, assuming the original callback is memoized.