Repository navigation
Rename relation props in config - #3817
Merged
Merged
Conversation
m-bert
approved these changes
Nov 13, 2025
m-bert
left a comment
m-bert
left a comment
Collaborator
There was a problem hiding this comment.
I'm not entirely sold on
block, I'd love to hear opinions.
For me blocks would sound more natural, but on the other hand we have requireToFail not requires, so I'm not sure.
Member
Author
Yeah, I went with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the configuration fields used for gesture relations:
simultaneousWithExternalGesture->simultaneousWithrequireExternalGestureToFail->requireToFailblocksExternalGesture->blockI'm not entirely sold on
block, I'd love to hear opinions.Test plan
Static checks