Repository navigation
Rename onTouchesCancelled to onTouchesCancel - #3818
Merged
Merged
Conversation
m-bert
approved these changes
Nov 13, 2025
| onEnd?: ( | ||
| event: GestureStateChangeEvent<THandlerData>, | ||
| success: boolean | ||
| didSucceed: boolean |
Collaborator
There was a problem hiding this comment.
I'll bring this topic once again, what about moving didSucceed into event? This can be both good and bad idea at the same time, so let me know what you think 😅
Member
Author
There was a problem hiding this comment.
It already is inside the event, kind of. didSucceed is true when the new state is END, and false when the new state is CANCELLED or FAILED.
We can come back to the idea together with changing the state info. Do we want to hide the state info from the public API entirely?
I'll go with merging this for now, since this rename doesn't change the discussion in any way 😅.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames
onTouchesCancelledtoonTouchesCancelto unify the naming convention.Also changes
successtodidSucceed, but this change should be transparent, besides code hints.Test plan
Static checks