Repository navigation
Handle testID prop - #3838
Merged
Merged
Handle testID prop#3838
testID prop#3838Conversation
m-bert
commented
Nov 25, 2025
Comment on lines
+31
to
+35
| if (key === 'testID') { | ||
| res.gestureHandlerProps[key] = props[key]; | ||
| // @ts-ignore FIXME(TS) | ||
| res.childProps[key] = props[key]; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
The idea here is to use the same testID for both, component and gesture. This way, it is possible to use getByGestureTestId, which returns gesture, and locate component by the same ID (though I have not tested that with other testing tools).
If you can see that this fails, let me know.
j-piasecki
reviewed
Nov 28, 2025
j-piasecki
reviewed
Nov 28, 2025
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
j-piasecki
approved these changes
Dec 5, 2025
m-bert
added a commit
that referenced
this pull request
Aug 24, 2026
## Description Two small cleanups: - The path filter in `rngh-api-v3.yml` pointed at `API_V3.test.tsx`, but the file is `api_v3.test.tsx` and GitHub path filters are case-sensitive, so a PR touching only the v3 test suite never triggered the workflow. The mismatch has been there since the workflow was added in #3838. Also lowercased the pattern in the `yarn test` step to match the file literally (it worked before only because jest matches patterns case-insensitively). - Removed `android/common/src/main/java/` from `files` in `package.json` - the directory was deleted in #3544, npm silently ignores the unmatched entry. ## Test plan - `npx jest --listTests RelationsTraversal api_v3` still selects both test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds handling of
testIDproperty.Test plan
yarn test api_v3