Repository navigation
Change runCallback types - #3860
Merged
Merged
Conversation
Member
|
Won't this break if we decide to bring the state manager back in its original form? |
Collaborator
Author
It will, we will decide what to do with this PR on the next meeting. I've left that opened for the time being. |
Member
|
I think we can go with that as-is, since state manager will change, no? |
m-bert
commented
Dec 15, 2025
| } | ||
|
|
||
| if (didSucceed === undefined) { | ||
| (handler as SingleParameterCallback<typeof event>)(event); |
Collaborator
Author
There was a problem hiding this comment.
I know that theoretically we have two possibilities - GestureEventCallbackand GestureTouchEventCallback. However, since those calls will differ only by cast, the resulting JS will look like this:
if(...) {
handler(event)
} else {
handler(event)
}So I don't think it makes sense to keep them separated.
j-piasecki
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
...unknown[]fromrunCallbackfunction, as in V3 it is alwaysboolean.Test plan
yarn ts-check