Repository navigation
[Android] Fix ScrollView - #3867
Merged
Merged
Conversation
m-bert
marked this pull request as draft
December 8, 2025 12:35
Collaborator
Author
|
Converted to draft as there's another problem on Android - scroll starts working when pointer is released. |
m-bert
marked this pull request as ready for review
December 9, 2025 13:40
j-piasecki
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that
ScrollViewdid not work on Android. There were two issues with that:GHScrollViewreceived wrong prop. For some reason linter did not catch that.RefreshControlwas blocking scroll at the top of the list.This PR changes prop name to the correct one and adds check for scrolling direction so that
RefreshControlno longer blocks scrolling.Test plan
ScrollView and FlatList examples.