Skip to content

[iOS] Preserve disabled button targets under box-none parents #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
Sep 11, 2026
Merged

[iOS] Preserve disabled button targets under box-none parents #4506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec0108
Preserve disabled button targets under box-none parents
rileysay Sep 9, 2026
a1c6a94
Skip box-none and none buttons in shouldHandleTouch
rileysay Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,6 @@ - (void)mouseDown:(NSEvent *)event
return;
}


_isTouchInsideBounds = YES;
[self handleAnimatePressIn];
[super mouseDown:event];
Expand All @@ -1208,7 +1207,7 @@ - (void)mouseUp:(NSEvent *)event
if (!_userEnabled) {
return;
}

NSPoint locationInView = [self convertPoint:[event locationInWindow] fromView:nil];
_isHovered = NSPointInRect(locationInView, self.bounds);
[self recordHoverSampleForMouseEvent:event];
Expand All @@ -1224,7 +1223,7 @@ - (void)mouseDragged:(NSEvent *)event
if (!_userEnabled) {
return;
}

NSPoint locationInWindow = [event locationInWindow];
NSPoint locationInView = [self convertPoint:locationInWindow fromView:nil];
BOOL currentlyInside = NSPointInRect(locationInView, self.bounds);
Expand Down Expand Up @@ -1260,7 +1259,7 @@ - (BOOL)beginTrackingWithTouch:(UITouch *)touch withEvent:(UIEvent *)event
if (!_userEnabled) {
return NO;
}

_isTouchInsideBounds = YES;
// A pencil's hover-out arrives just before touch-down but only schedules the
// clear, so `_isHovered` still reflects the open hover. Under Reduce Motion
Expand Down Expand Up @@ -1426,7 +1425,8 @@ - (BOOL)shouldHandleTouch:(RNGHUIView *)view atPoint:(CGPoint)point
{
if ([view isKindOfClass:[RNGestureHandlerButton class]]) {
RNGestureHandlerButton *button = (RNGestureHandlerButton *)view;
return button.userEnabled;
return button.userEnabled && button.pointerEvents != RNGestureHandlerPointerEventsBoxNone &&
button.pointerEvents != RNGestureHandlerPointerEventsNone;
}

// Certain subviews such as RCTViewComponentView have been observed to have disabled
Expand Down Expand Up @@ -1473,7 +1473,9 @@ - (RNGHUIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
if (!subview.isHidden && subview.alpha > 0) {
CGPoint convertedPoint = [subview convertPoint:point fromView:self];
UIView *hitView = [subview hitTest:convertedPoint withEvent:event];
if (hitView != nil && [self shouldHandleTouch:hitView atPoint:point]) {
if (hitView != nil &&
([hitView isKindOfClass:[RNGestureHandlerButton class]] ||
[self shouldHandleTouch:hitView atPoint:point])) {
return hitView;
}
}
Expand Down
Loading