Skip to content

[Android] Don't change state of handlers that haven't received any touches #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
Oct 1, 2026
Merged

[Android] Don't change state of handlers that haven't received any touches #4549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be0158a
Don't change state of handlers without pointers
m-bert Sep 23, 2026
6d8285e
Merge branch 'main' into @mbert/state-manager-untouched-handler
m-bert Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...andler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ class RNGestureHandlerModule(reactContext: ReactApplicationContext?) :
UiThreadUtil.assertOnUiThread()

registry.getHandler(handlerTag)?.let { handler ->
if (handler.state == GestureHandler.STATE_UNDETERMINED && !handler.hasTrackedPointers) {
return
}

if (newState == GestureHandler.STATE_ACTIVE) {
// The first touch event reaches JS before the handler begins, so a handler
// that already tracks a pointer may still be UNDETERMINED here.
Expand Down
Loading