Skip to content

[iOS] Fix JS touches being cancelled when a ScrollView wrapped in a native gesture starts scrolling #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoonDong2 wants to merge 2 commits into from
Closed

[iOS] Fix JS touches being cancelled when a ScrollView wrapped in a native gesture starts scrolling #4574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a86adde
[iOS] Fix JS touches being cancelled when a ScrollView wrapped in a n…
JoonDong2 Oct 6, 2026
92063e7
[iOS] Keep the native scroll recognizer exception off macOS
JoonDong2 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,18 @@ - (void)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer
return;
}

#if !TARGET_OS_OSX
// A native handler bound to a ScrollView is attached to the component view that wraps the platform
// scroll view, so the check above does not recognize it as a scroll recognizer. On iOS its recognizer
// only mirrors the state of the scroll view's pan recognizer, so its activation means scrolling started.
// On macOS it begins on mouse down, so it is not skipped there.
RNGestureHandler *handler = [RNGestureHandler findGestureHandlerByRecognizer:gestureRecognizer];
if ([gestureRecognizer isKindOfClass:[RNDummyGestureRecognizer class]] && handler != nil &&
[handler retrieveScrollView:gestureRecognizer.view] != nil) {
return;
}
#endif

UIGestureRecognizer *touchHandler = nil;

// this way we can extract the touch handler on both architectures relatively easily
Expand Down