Skip to content

[Android] Check the overflow ancestor pass against the detector child's bounds #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 1 commit into from
Oct 16, 2026
Merged

[Android] Check the overflow ancestor pass against the detector child's bounds #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...ler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,9 +662,12 @@ class GestureHandlerOrchestrator(
}

// if the pointer is inside the view but it overflows its parent, handlers attached to the parent
// might not have been extracted (pointer might be in a child, but may be outside parent)
if (coords[0] in 0f..view.width.toFloat() &&
coords[1] in 0f..view.height.toFloat() &&
// might not have been extracted (pointer might be in a child, but may be outside parent).
// Checked against the same bounds as the handlers above: a detector frame widened to cover a
// transformed child overflows its parent, but a pointer in the area the child vacated is not
// over its content and must not record the ancestors ahead of the views behind it.
if (boundsX in 0f..boundsView.width.toFloat() &&
boundsY in 0f..boundsView.height.toFloat() &&
isViewOverflowingParent(view) &&
extractAncestorHandlers(view, coords, pointerId, event)
) {
Expand Down
Loading