Skip to content

Stop the Pressable long press timer on touch up #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 1 commit into from
Oct 27, 2026
Merged

Stop the Pressable long press timer on touch up #4644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native-gesture-handler/src/v3/components/StatefulPressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ const StatefulPressable = (props: PressableProps) => {
if (longPressTimeoutRef.current) {
clearTimeout(longPressTimeoutRef.current);
longPressTimeoutRef.current = null;
isOnPressAllowed.current = true;
}
}, []);

Expand All @@ -141,6 +140,7 @@ const StatefulPressable = (props: PressableProps) => {
if (onLongPress) {
cancelLongPress();
longPressTimeoutRef.current = setTimeout(() => {
longPressTimeoutRef.current = null;
isOnPressAllowed.current = false;
onLongPress(event);
}, delayLongPress ?? DEFAULT_LONG_PRESS_DURATION);
Expand Down Expand Up @@ -188,6 +188,7 @@ const StatefulPressable = (props: PressableProps) => {
}

isCurrentlyPressed.current = true;
isOnPressAllowed.current = true;
pressInEventRef.current = event;
if (unstable_pressDelay) {
pressDelayTimeoutRef.current = setTimeout(() => {
Expand Down Expand Up @@ -311,6 +312,11 @@ const StatefulPressable = (props: PressableProps) => {
pressableEvent
);
},
onTouchesUp: () => {
// The button may still be waiting for another gesture; a long press
// must not fire after the finger lifted
cancelLongPress();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
onTouchesCancel: (event) => {
const pressableEvent = gestureTouchToPressableEvent(event);
stateMachine.reset();
Expand Down
Loading