Preserve adjacent negative polygon coordinates - #3027
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractPolyPointstries to insert a separator before a minus sign that follows another coordinate, but its regex consumes the preceding character and replaces only the first match. Valid points such as0,0 10-10 20-20become0 0 1 -10 20-20, corrupting Polygon and Polyline geometry.Capture and preserve the character before each adjacent minus and apply the replacement globally. Exponent signs such as
1e-3remain part of the same number.Test Plan
What is required?
The existing Jest environment.
Steps and results
10and leaves the second pair unsplit.1e-3remains intact.yarn test,yarn bob, andgit diff --checkpass.Compatibility
Checklist
README.md— no public API or documentation change__tests__folderBreaking changes
Only previously corrupted valid point strings change; API and correctly parsed inputs are unchanged.