-
Notifications
You must be signed in to change notification settings - Fork 3
Add FOSSA SCA scanning and dependency manifest registration [skip ci] #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| version: 3 | ||
|
|
||
| project: | ||
| locator: solacecommunity_angular-solace-message-client | ||
| id: solacecommunity_angular-solace-message-client | ||
| name: angular-solace-message-client | ||
| teams: [] | ||
| labels: | ||
| - typescript | ||
|
|
||
| vendoredDependencies: | ||
| forceRescans: false | ||
| scanMethod: CLILicenseScan | ||
| licenseScanPathFilters: | ||
| exclude: | ||
| - "./.git" | ||
| - "./.github" | ||
|
|
||
| paths: | ||
| exclude: | ||
| - ./.git | ||
| - ./.github | ||
|
|
||
| telemetry: | ||
| scope: full | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "sca_scanning": { | ||
| "fossa": { | ||
| "policy": { "mode": "REPORT" }, | ||
| "vulnerability": { "mode": "REPORT" } | ||
| } | ||
| } | ||
| } |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, squash both commits into a single one according to the Contributing guidelines. Commit message:
|
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,67 @@ | ||||||||
| name: SCA Scan | ||||||||
| on: | ||||||||
| pull_request: | ||||||||
| branches: [master] | ||||||||
| push: | ||||||||
| branches: [master] | ||||||||
| workflow_dispatch: | ||||||||
|
|
||||||||
| permissions: | ||||||||
| contents: read | ||||||||
| id-token: write | ||||||||
| packages: read | ||||||||
| actions: read | ||||||||
| statuses: write | ||||||||
| checks: write | ||||||||
| pull-requests: write | ||||||||
|
|
||||||||
| jobs: | ||||||||
| sca_scan: | ||||||||
| uses: SolaceDev/solace-public-workflows/.github/workflows/sca-scan-and-guard.yaml@main | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are two failures: FOSSA Vulnerability Check and FOSSA Policy/Licensing Check We cannot access the SCA Scan Results mentioned here:
Can you login and see the problems? Out maintainer team also needs access so that we can fix any potential vulnerabilities and violations. Can you authorize us? |
||||||||
| with: | ||||||||
| setup_actions: '["setup-node"]' | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||
| secrets: | ||||||||
| FOSSA_API_KEY: ${{ secrets.FOSSA_API_KEY }} | ||||||||
|
|
||||||||
| update_manifest: | ||||||||
| needs: sca_scan | ||||||||
| # The manifest records what landed on the default branch, so it must never | ||||||||
| # be written from a PR run -- the scan still runs, the write does not. | ||||||||
| # | ||||||||
| # workflow_dispatch is allowed so this repo can be merged with a skip-ci | ||||||||
| # commit (which suppresses every workflow on that push, including the | ||||||||
| # release/publish one) and then have the scan and manifest write triggered | ||||||||
| # by hand. The default-branch check still applies, so dispatching against | ||||||||
| # any other ref scans without writing. | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please simplify comment, for example like this: |
||||||||
| if: >- | ||||||||
| needs.sca_scan.result == 'success' | ||||||||
| && (github.event_name == 'push' || github.event_name == 'workflow_dispatch') | ||||||||
| && github.ref_name == github.event.repository.default_branch | ||||||||
| runs-on: ubuntu-latest | ||||||||
| permissions: | ||||||||
| id-token: write | ||||||||
| contents: read | ||||||||
| packages: read | ||||||||
| steps: | ||||||||
| - name: Configure AWS credentials | ||||||||
| uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4 | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| with: | ||||||||
| role-to-assume: ${{ secrets.MANIFEST_AWS_ROLE }} | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the secret MANIFEST_AWS_ROLE in the repository settings? |
||||||||
| aws-region: us-east-1 | ||||||||
|
|
||||||||
| - name: Update solace-cloud-manifest | ||||||||
| uses: SolaceDev/solace-public-workflows/.github/actions/cicd-helper@main | ||||||||
| with: | ||||||||
| rc_step: add_item_from_json_to_dynamodb_table | ||||||||
| ddb_table_name: solace-cloud-manifest | ||||||||
| ddb_partition_key: squad | ||||||||
| ddb_sort_key: repository | ||||||||
| ddb_item_to_be_added: | | ||||||||
| { | ||||||||
| "squad": "cto", | ||||||||
| "repository": "${{ github.event.repository.name }}", | ||||||||
| "dev": { | ||||||||
| "sha": "${{ github.sha }}", | ||||||||
| "version": "${{ github.ref_name }}" | ||||||||
| } | ||||||||
| } | ||||||||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please ensure that only path
dist/@solace-communityis scanned? This is the effective lib which is pushed in npm. The test project should not be scanned and should not report any false positives, since it is not used in any production code.