Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .fossa.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
version: 3

project:
locator: solacecommunity_angular-solace-message-client
id: solacecommunity_angular-solace-message-client
name: angular-solace-message-client
teams: []
labels:
- typescript

vendoredDependencies:
forceRescans: false
scanMethod: CLILicenseScan
licenseScanPathFilters:
exclude:
- "./.git"
- "./.github"

paths:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please ensure that only path dist/@solace-community is scanned? This is the effective lib which is pushed in npm. The test project should not be scanned and should not report any false positives, since it is not used in any production code.

exclude:
- ./.git
- ./.github

telemetry:
scope: full
8 changes: 8 additions & 0 deletions .github/workflow-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"sca_scanning": {
"fossa": {
"policy": { "mode": "REPORT" },
"vulnerability": { "mode": "REPORT" }
}
}
}
67 changes: 67 additions & 0 deletions .github/workflows/sca-scan-and-guard.yml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash both commits into a single one according to the Contributing guidelines. Commit message:

ci: add FOSSA SCA scanning and dependency manifest registration

Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
name: SCA Scan
on:
pull_request:
branches: [master]
push:
branches: [master]
workflow_dispatch:

permissions:
contents: read
id-token: write
packages: read
actions: read
statuses: write
checks: write
pull-requests: write

jobs:
sca_scan:
uses: SolaceDev/solace-public-workflows/.github/workflows/sca-scan-and-guard.yaml@main

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two failures: FOSSA Vulnerability Check and FOSSA Policy/Licensing Check

We cannot access the SCA Scan Results mentioned here:
https://github.com/solacecommunity/angular-solace-message-client/actions/runs/33565503264

https://app.fossa.com/projects/custom%2B48578%2Fsolacecommunity_angular-solace-message-client/refs/branch/PR/add-fossa-sca-scanning%0A

Image

Can you login and see the problems?

Out maintainer team also needs access so that we can fix any potential vulnerabilities and violations. Can you authorize us?

with:
setup_actions: '["setup-node"]'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setup_actions: '["setup-node"]'
setup_actions: '["setup-node"]'
node_version: "24"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secrets:
FOSSA_API_KEY: ${{ secrets.FOSSA_API_KEY }}

update_manifest:
needs: sca_scan
# The manifest records what landed on the default branch, so it must never
# be written from a PR run -- the scan still runs, the write does not.
#
# workflow_dispatch is allowed so this repo can be merged with a skip-ci
# commit (which suppresses every workflow on that push, including the
# release/publish one) and then have the scan and manifest write triggered
# by hand. The default-branch check still applies, so dispatching against
# any other ref scans without writing.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify comment, for example like this:

    # Update the manifest only on master-branch pushes or manual runs, never PRs.
    # Manual runs allow scanning and updating after [skip ci] without releasing.

if: >-
needs.sca_scan.result == 'success'
&& (github.event_name == 'push' || github.event_name == 'workflow_dispatch')
&& github.ref_name == github.event.repository.default_branch
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
packages: read
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
uses: aws-actions/configure-aws-credentials@v6

with:
role-to-assume: ${{ secrets.MANIFEST_AWS_ROLE }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the secret MANIFEST_AWS_ROLE in the repository settings?

aws-region: us-east-1

- name: Update solace-cloud-manifest
uses: SolaceDev/solace-public-workflows/.github/actions/cicd-helper@main
with:
rc_step: add_item_from_json_to_dynamodb_table
ddb_table_name: solace-cloud-manifest
ddb_partition_key: squad
ddb_sort_key: repository
ddb_item_to_be_added: |
{
"squad": "cto",
"repository": "${{ github.event.repository.name }}",
"dev": {
"sha": "${{ github.sha }}",
"version": "${{ github.ref_name }}"
}
}