Ensure context propagation for all stages of the Completab… - #51
Merged
helios57 merged 2 commits intoMay 28, 2026
Merged
Conversation
cedric-schaller
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #50 by ensuring Micrometer/OpenTelemetry context (e.g., MDC trace/span IDs) is propagated across asynchronous CompletableFuture execution in RequestReplyServiceImpl, so downstream stages added by callers don’t unexpectedly lose context.
Changes:
- Replaced per-invocation
ContextSnapshot.wrap(runnable)with a context-propagating wrappedExecutorService(ContextExecutorService.wrap(...)). - Updated
CompletableFuture.runAsync(...)andwhenCompleteAsync(...)to use the wrapped executor service. - Adjusted
runningRequests()to use the underlyingThreadPoolExecutorforgetActiveCount().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds an integration test class that verifies the MDC / thread-local context captured on the calling thread is propagated to the request-sending thread and to stages chained on the returned CompletableFuture, and that context is not leaked between pooled requests. Also renames WRAPPED_EXECUTOR to DELEGATE_EXECUTOR to make clear it is the executor being wrapped by the context-propagating one.
helios57
approved these changes
May 28, 2026
GreenRover
approved these changes
May 28, 2026
nathanaelweber
approved these changes
May 28, 2026
SamuelGasser
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #50