Repository navigation
build(block-list): CLI on Agave 4.3.2, SDK on the Solana 3 component crates - #773
Merged
Merged
Conversation
…crates - cli: solana-clap-v3-utils, solana-cli-config, solana-client and solana-remote-wallet 4.3.2 (behind their agave-unstable-api feature), solana-sdk 4.1, solana-logger 3, spl-tlv-account-resolution 0.11 and spl-transfer-hook-interface 2.1. CommitmentConfig now comes from solana-commitment-config. The unused futures-util and spl-token-client dependencies are dropped. - sdk/rust: the manifest matches what the Codama Rust renderer now generates (solana-address 2, solana-instruction/account-info/cpi 3, thiserror, num-derive), with the optional fetch and serde features. It previously declared the 2.x crates and kaigan, so the generated client did not compile. - build-and-test also builds the CLI, so CI catches it rotting again.
Contributor
 [Low impact] No established issue blocks merging this PR. SummaryUpdates the block-list CLI to Agave 4.3.2 and moves the Rust SDK to Solana component crates.
Reviews (2) · Last reviewed commit: "build(block-list): build the CLI without..." · Reviewed by Greptile |
amilz
previously approved these changes
Oct 28, 2026
amilz
left a comment
amilz
left a comment
Collaborator
There was a problem hiding this comment.
Moves block-list pinocchio CLI to Agave 4.3.2 / solana-sdk 4.1 and the Rust SDK to Solana 3 component crates; CLI now built in CI. LGTM.
solana-remote-wallet's default linux-static-hidraw feature pulls hidapi, whose build script needs the system libudev the runners lack. Keypair-file and URL signers are unaffected; only USB hardware wallets drop out.
amilz
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of step 4 (Rust dependencies): the block-list pinocchio CLI and Rust SDK were the last crates on Solana 2.x.
Changes
solana-clap-v3-utils,solana-cli-config,solana-client,solana-remote-wallet. Since Agave 3 these gate their API behind theagave-unstable-apifeature, so it is enabled.solana-sdk4.1 (not 5: Agave 4.3 and the SPL interfaces are still on the sdk-4 crate family),solana-logger3,spl-tlv-account-resolution0.11,spl-transfer-hook-interface2.1.CommitmentConfigis imported fromsolana-commitment-config(moved out ofsolana-sdk); no other code change was needed.futures-utilandspl-token-client.fetch/serdefeatures), same as the games' clients. It still declared the 2.x crates plus kaigan, so the generated client did not compile. The generated code'sanchorcfgs are declared incheck-cfg.build-and-testnow runscargo build -p block-list-cli, which the pinocchio workflow already calls. Before this, nothing compiled the CLI.Testing
cargo build -p block-list-cliandcargo clippy -p block-list-cli -p block-list-clientwith zero warnings,cargo fmt --checkclean,block-list-cli --helpruns, and the program tests compile (cargo test -p block-list --no-run).AI disclosure