Repository navigation
build(games): pinocchio-token 0.7, pinocchio-token-2022 0.4, codama 0.13 - #774
Merged
Merged
Conversation
- gacha's prize NFT CPIs use the pinocchio-token 0.7 constructors (InitializeMint2::new, MintTo::new, SetAuthority::new); the program type now comes from the Token-2022 aliases instead of a token_program field. - codama 0.13.2 regenerates both IDLs: empty arrays are omitted, the omitted discriminator fields carry a skip display node, and the root version is 1.8.0. The generated Rust clients are unchanged. - The Light integration tests stay on light-program-test 0.23, the latest release, which still pins its own Solana 2.x and litesvm stack.
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryUpdates token dependencies and pins Rust
Reviews (1) · Last reviewed commit: "build(games): pinocchio-token 0.7, pinoc..." · Reviewed by Greptile |
amilz
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last part of step 4 (Rust dependencies): the games' own workspaces.
Changes
pinocchio-token0.6 → 0.7 (world-cup) andpinocchio-token-20220.3.1 → 0.4 (both). Gacha's prize-NFT CPIs move to the 0.7 constructors (InitializeMint2::new,MintTo::new,SetAuthority::new), with the program type supplied by the Token-2022 aliases rather than atoken_programfield. World-cup needed no code change.codama=0.9.3→=0.13.2(exact pin kept, since it decides the committed IDL). Both IDLs are regenerated: empty arrays are omitted, omitted discriminator fields carry astructFieldDisplayNode(skip: always), and the root version is 1.8.0. The generated Rust clients are byte-identical.light-program-test0.23, the latest release, which still pins its own Solana 2.x and litesvm 0.7 stack (as the justfile documents).Testing
cargo test --workspace --no-run,cargo clippy --workspace --all-targets -D warnings(the client excluded, as in the justfile) andcargo fmt --checkfor both games;cargo check --testsfor the Light tests;generate-idl+generate-clientsleave the committed clients unchanged.just.yml: setup, check-generated, build, test).AI disclosure