feat(rpc): add costUnits to transaction meta - #494
Conversation
Greptile SummaryAdds nullable
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "feat(rpc): add costUnits to transaction ..." | Re-trigger Greptile |
|
good catch @sduchesneau to bypass commitlint, could you run the next commands locally: git commit --amend -m "feat(rpc): add costUnits to transaction meta"
git push --force-with-lease |
5d92ea1 to
d6255cc
Compare
do you need a signed commit on top of that ? |
yes, sorry forget to mention, signed commit is mandatory you can check the next links:
after creating a signing key, you can add this public key on GH under and after that: git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true # then -S is implicitand your previous commit message rename should look like follows: git commit --amend -S -m "feat(rpc): add costUnits to transaction meta"
git push --force-with-lease |
d6255cc to
7cbacec
Compare
|
@sonicfromnewyoke should be good to go if you can approve the workflows again (same commit, with signature) Thanks! |
many thanks for contribution 💪 |
The RPC reports the block cost model charge alongside the compute units consumed, on both the binary and the jsonParsed transaction meta.