Add implementation of draft react spec - #524
Open
skizzerz wants to merge 3 commits into
Open
Conversation
For +draft/react, we limit the reaction to a single emoji (potentially including modifiers) for similar reasons. Additionally, the +draft/unreact tag was implemented as a means for users to easily remove their reactions. This dependence on emoji brings in a new dependency on libicu.
If icu is disabled via command line flags but hyperscan is enabled, the compile flags will remove any hyperscan headers/libs from the build. Ensure we properly update save_CPPFLAGS and save_LIBS before each check.
Add details about the two new client tags supported by this extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For +draft/react, we limit the reaction to a single emoji (potentially including modifiers) for easier moderation (since this doesn't go through spamfilter). Additionally, the +draft/unreact tag was implemented as a means for users to easily remove their reactions. This dependence on emoji brings in a new dependency on libicu.