Repository navigation
feat(tests): fail smoke when a fork edits an upstream manifest key (#1923) - #1960
Merged
Merged
Conversation
…1923) SYS-20 compares core, base, backend and frontend with the revision a fork last merged, the merge base of HEAD and SAIT_UPSTREAM_REF, and names each entry added, removed or changed. Upstream sets no ref and compares the manifest with itself; planted pairs exercise the failing path every run. Per-directory manifest fragments are not added: the check enforces the rule, and fragments would change the schema 3.x freezes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1923.
What
tests/run_smoke.py, specSAIT-SMK-SYS-20-001A, INDEX row) compares the manifest's upstream keys (core,base,backend,frontend) with a baseline. It names each entry added, removed or changed, with the fields that changed.SAIT_UPSTREAM_REFnames a ref holding upstream's history. The baseline is the merge base of HEAD and that ref: the revision the fork last merged.Decided here: no manifest fragments
The issue left per-directory manifest fragments as optional insurance. They are not added: the check enforces the rule, and fragments would change the manifest schema that the 3.x line freezes. If forks still hit merge conflicts in the manifest, fragments can arrive later as an additive schema change.
Verification
run_smoke.py35/35.run_conformance.py0 failed; its readings: release ordering has no other ready PR, no off-limits path is touched, and the test change is SYS-20 added.sync.py --checkis clean.SAIT_UPSTREAM_REF=fcb8585~1flags exactlybase: base-agents changed (description), the edit feat(templates): generate inline or hybrid, and inline a rule that breaks silently (#712) #1959 made. A ref sharing no history fails with the git error.🤖 Generated with Claude Code