Skip to content

Commit 33cf6ae

Browse files
committed
chore: bump examples to @solidjs/testing-library 1.0.0-beta.2 for Solid 2.0
The 0.8.x line imports solid-js/web, a subpath removed in Solid 2.0, which broke the Vitest browser tests in the vite-6/7/8 examples during dep pre-bundling. The 1.0.0-beta line targets Solid 2.0 (@solidjs/web). Also align the vite-7/8 test text expectations with their App titles. Made-with: Cursor
1 parent 1df46d6 commit 33cf6ae

7 files changed

Lines changed: 24 additions & 25 deletions

File tree

examples/vite-6/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"test-dev": "vitest"
1111
},
1212
"devDependencies": {
13-
"@solidjs/testing-library": "^0.8.10",
13+
"@solidjs/testing-library": "^1.0.0-beta.2",
1414
"@testing-library/jest-dom": "^6.6.3",
1515
"@testing-library/user-event": "^14.6.1",
1616
"@vitest/browser": "^3.0.7",

examples/vite-7/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"test-dev": "vitest"
1111
},
1212
"devDependencies": {
13-
"@solidjs/testing-library": "^0.8.10",
13+
"@solidjs/testing-library": "^1.0.0-beta.2",
1414
"@testing-library/jest-dom": "^6.6.3",
1515
"@testing-library/user-event": "^14.6.1",
1616
"@vitest/browser": "^3.0.7",

examples/vite-7/tests/App.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ import App from '../src/App.jsx';
88
test('App', async () => {
99
const root = page.elementLocator(render(() => <App />).baseElement);
1010

11-
const count = root.getByText('Count:');
12-
await expect.element(count).toHaveTextContent('Count: 0');
11+
const count = root.getByText('Counter:');
12+
await expect.element(count).toHaveTextContent('Counter: 0');
1313

1414
const incrementButton = root.getByText('Increment');
1515
await incrementButton.click();
16-
await expect.element(count).toHaveTextContent('Count: 1');
16+
await expect.element(count).toHaveTextContent('Counter: 1');
1717

1818
const decrementButton = root.getByText('Decrement');
1919
await decrementButton.click();
20-
await expect.element(count).toHaveTextContent('Count: 0');
20+
await expect.element(count).toHaveTextContent('Counter: 0');
2121
});

examples/vite-8/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"test-dev": "vitest"
1111
},
1212
"devDependencies": {
13-
"@solidjs/testing-library": "^0.8.10",
13+
"@solidjs/testing-library": "^1.0.0-beta.2",
1414
"@testing-library/jest-dom": "^6.6.3",
1515
"@testing-library/user-event": "^14.6.1",
1616
"@vitest/browser": "^3.0.7",

examples/vite-8/tests/App.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ import App from '../src/App.jsx';
88
test('App', async () => {
99
const root = page.elementLocator(render(() => <App />).baseElement);
1010

11-
const count = root.getByText('Count:');
12-
await expect.element(count).toHaveTextContent('Count: 0');
11+
const count = root.getByText('Counter:');
12+
await expect.element(count).toHaveTextContent('Counter: 0');
1313

1414
const incrementButton = root.getByText('Increment');
1515
await incrementButton.click();
16-
await expect.element(count).toHaveTextContent('Count: 1');
16+
await expect.element(count).toHaveTextContent('Counter: 1');
1717

1818
const decrementButton = root.getByText('Decrement');
1919
await decrementButton.click();
20-
await expect.element(count).toHaveTextContent('Count: 0');
20+
await expect.element(count).toHaveTextContent('Counter: 0');
2121
});

pnpm-lock.yaml

Lines changed: 12 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ minimumReleaseAgeExclude:
2727
- '@dom-expressions/compiler-win32-x64-msvc@0.50.0-next.25'
2828
- '@dom-expressions/compiler-wasm32-wasi@0.50.0-next.25'
2929
- '@dom-expressions/compiler@0.50.0-next.25'
30+
- '@solidjs/testing-library@1.0.0-beta.2'
3031

3132
onlyBuiltDependencies:
3233
- cypress

0 commit comments

Comments
 (0)