fix: full-reload on document shell and server-only module edits - #336
Open
ryansolid wants to merge 1 commit into
Open
fix: full-reload on document shell and server-only module edits#336ryansolid wants to merge 1 commit into
ryansolid wants to merge 1 commit into
Conversation
…djs/solid#3151) The document shell hydrates the whole document, so no refresh-boundary component swap can ever apply an edit to it — updates were accepted and silently absorbed. The client compile of the resolved start.document / src/Document.* module now declines HMR (self-accept + invalidate), so a save full-reloads the page. Separately, server-environment hot updates for files with no modules in the client graph (client-mode documents, authored entry-server, middleware) now send a browser full-reload instead of being suppressed: the suppression protects client HMR from full-reload races, but a server-only file has no client update to race with — staying silent just leaves the browser rendering stale server output. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 3a7ff44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes solidjs/solid#3151 (Document.jsx edits don't HMR or reload).
Two sides, both in dev serving:
documentthrough the resolvedstart.document/src/Document.*module, so no refresh-boundary component swap can ever apply an edit to it — updates were accepted and silently absorbed. The document module's client compile now skips the refresh boundary and appends a self-accept +invalidate()footer, so a save full-reloads the page. Config-driven off the already-resolved document id — no source sniffing.hotUpdatehook suppresses server-environment updates to keep full-reload messages from racing client HMR — but a file with no modules in the client graph (client-mode document shells, authored entry-server,start.middleware) has no client update to race with, and staying silent leaves the browser rendering stale server output. Those now send a browser full-reload.Test plan
examples/start-ssr: document client compile carries the decline footer and no refresh boundary (SSR compile unaffected);App.tsxkeeps its normal refresh boundary; editingsrc/middleware.tssends the browser afull-reload; editingApp.tsxsends a plain HMRupdatewith no full-reload.examples/start-ssrharness modesdev,document,babel-hmrpass;middlewaremode has one pre-existing failure ("Unknown server function") that reproduces on a clean tree.Made with Cursor