Suppress expected OAuth access denial reports

Author: korridor

app/Exceptions/Handler.php

@@ -7,6 +7,7 @@
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
+use League\OAuth2\Server\Exception\OAuthServerException;
 use Symfony\Component\HttpFoundation\Exception\SuspiciousOperationException;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
@@ -34,6 +35,10 @@ public function register(): void
             //
         });
 
+        $this->dontReportWhen(fn (Throwable $e): bool => $e instanceof OAuthServerException
+            && $e->getErrorType() === 'access_denied'
+            && $e->getHttpStatusCode() === 401);
+
         // A request on an untrusted host (see App\Http\Middleware\TrustHosts)
         // otherwise renders as a bare "Bad request." 400. Show a message that
         // says how to fix it instead. The framework has already converted the

tests/Unit/Exceptions/Api/ApiExceptionTest.php

@@ -63,7 +63,13 @@ public static function expectedApiExceptionProvider(): iterable
     #[DataProvider('expectedApiExceptionProvider')]
     public function test_expected_api_exceptions_are_not_reported(ApiException $exception): void
     {
-        $this->assertTrue($exception->report());
+        // Arrange: exception supplied by the data provider
+
+        // Act
+        $reportingHandled = $exception->report();
+
+        // Assert
+        $this->assertTrue($reportingHandled);
     }
 
     /**
@@ -79,6 +85,12 @@ public static function operationalApiExceptionProvider(): iterable
     #[DataProvider('operationalApiExceptionProvider')]
     public function test_operational_api_exceptions_are_reported(ApiException $exception): void
     {
-        $this->assertFalse($exception->report());
+        // Arrange: exception supplied by the data provider
+
+        // Act
+        $reportingHandled = $exception->report();
+
+        // Assert
+        $this->assertFalse($reportingHandled);
     }
 }

tests/Unit/Exceptions/HandlerTest.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Exceptions;
+
+use App\Exceptions\Handler;
+use League\OAuth2\Server\Exception\OAuthServerException;
+use RuntimeException;
+use Tests\TestCase;
+
+class HandlerTest extends TestCase
+{
+    public function test_oauth_access_denied_exceptions_are_not_reported(): void
+    {
+        // Arrange
+        $exception = OAuthServerException::accessDenied(
+            'Access token could not be verified',
+            previous: new RuntimeException('The token is expired')
+        );
+
+        // Act
+        $shouldReport = app(Handler::class)->shouldReport($exception);
+
+        // Assert
+        $this->assertFalse($shouldReport);
+    }
+
+    public function test_operational_oauth_exceptions_are_reported(): void
+    {
+        // Arrange
+        $exception = OAuthServerException::serverError('Signing key could not be read');
+
+        // Act
+        $shouldReport = app(Handler::class)->shouldReport($exception);
+
+        // Assert
+        $this->assertTrue($shouldReport);
+    }
+}