Repository navigation
Commit 64d495f
fix!: correct silent-success defects and release v2.0.0 (#58)
* fix: correct silent-success defects and prepare the v0.1.0 release
Several paths let the engine do the wrong thing and still report success,
which nothing in the suite or a user's logs would have caught.
Fixed:
- Compound conditions took the wrong branch. ConditionEvaluator had no
&& / || support but swallowed the operator into the right-hand side and
string-compared, so 'order.total > 1000 && order.vip === true' was true
for a 500 dollar order. Boolean operators, parentheses and negated
groups are now supported; a malformed expression throws instead of
collapsing to a boolean.
- resume() on a failed workflow threw "Cannot transition from 'failed' to
'failed'" from inside the failure handler, destroying the original
cause. FAILED -> RUNNING is now legal, resume retries the failed step,
and the handler can no longer mask the real error.
- Multi-root workflows executed one root and still reported COMPLETED.
- Steps reachable only from each other are rejected at parse time.
- Relational comparisons against a missing key are false (null coerces
to 0, so 'missing.key < 1000' used to be true).
- start() threw instead of overwriting an existing instance.
- Workflows blocked on unmet prerequisites park in WAITING.
- DelayAction honours the documented minutes/hours keys.
- HttpAction reports missing ext-curl as a step failure.
Breaking (pre-1.0, each with a migration note in CHANGELOG.md):
- EmailAction -> FakeEmailAction; it never sent mail but reported
'status' => 'sent'. Payload is now 'sent' => false, 'mock' => true.
- WorkflowBuilder::email() -> fakeEmail().
- ConditionAction drops the non-functional on_true/on_false and uses the
shared condition grammar instead of its own '=' / 'is' parser.
- FAILED is no longer terminal.
Added:
- Storage\InMemoryStorage now ships with the package; previously the only
adapter lived in tests/ so the library could not run out of the box.
- CI runs on pull requests, not just pushes.
- SECURITY.md; corrected README action table and attribute examples.
- Regression tests for every issue above (116 -> 161 tests).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* ci: add PHP 8.5 to the test matrix
Now installable there since #57 widened the dev tooling constraints. The
library accepts php: ^8.3, which admits 8.5, so it should be tested there.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 3713b2f commit 64d495f
41 files changed
Lines changed: 1878 additions & 289 deletions
File tree
- .github/workflows
- docs
- src
- Actions
- Core
- Exceptions
- Storage
- Support
- tests
- Integration
- Support
- Unit
- Support
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
13 | 22 | | |
14 | 23 | | |
15 | 24 | | |
| |||
18 | 27 | | |
19 | 28 | | |
20 | 29 | | |
21 | | - | |
| 30 | + | |
22 | 31 | | |
23 | 32 | | |
24 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
8 | 110 | | |
9 | 111 | | |
10 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
78 | 83 | | |
79 | 84 | | |
80 | 85 | | |
| |||
154 | 159 | | |
155 | 160 | | |
156 | 161 | | |
157 | | - | |
158 | | - | |
| 162 | + | |
| 163 | + | |
159 | 164 | | |
160 | 165 | | |
161 | 166 | | |
162 | 167 | | |
163 | 168 | | |
164 | 169 | | |
165 | | - | |
166 | | - | |
167 | | - | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
168 | 173 | | |
0 commit comments