Merge pull request #16 from terwey/fix/vaultaddr-response-parsing

Fix/vaultaddr response parsing

Author: sonirico

api.go

@@ -46,14 +46,18 @@ func (r *APIResponse[T]) UnmarshalJSON(data []byte) error {
 
 	// When status is "ok", "response" contains "type" and "data"
 	r.Type = string(parsed.GetStringBytes("response", "type"))
-	responseData := parsed.GetStringBytes("response", "data")
+
+	// GetStringBytes() only works on string, we should do a Get instead
+	responseData := parsed.Get("response", "data")
 
 	if responseData == nil {
 		return fmt.Errorf("missing response.data field in successful response")
 	}
 
+	b := responseData.MarshalTo(nil)
+
 	// Use fastjson's built-in unmarshaling if possible, fallback to json.Unmarshal
-	if err := json.Unmarshal(responseData, &r.Data); err != nil {
+	if err := json.Unmarshal(b, &r.Data); err != nil {
 		return fmt.Errorf("failed to unmarshal response data: %w", err)
 	}
 

exchange.go

@@ -70,17 +70,19 @@ func (e *Exchange) postAction(
 		"signature": signature,
 	}
 
-	// Handle vault address based on action type
-	if actionMap, ok := action.(map[string]any); ok {
-		if actionMap["type"] != "usdClassTransfer" {
-			payload["vaultAddress"] = e.vault
+	if e.vault != "" {
+		// Handle vault address based on action type
+		if actionMap, ok := action.(map[string]any); ok {
+			if actionMap["type"] != "usdClassTransfer" {
+				payload["vaultAddress"] = e.vault
+			} else {
+				payload["vaultAddress"] = nil
+			}
 		} else {
-			payload["vaultAddress"] = nil
+			// For struct types, we need to use reflection or type assertion
+			// For now, assume it's not usdClassTransfer
+			payload["vaultAddress"] = e.vault
 		}
-	} else {
-		// For struct types, we need to use reflection or type assertion
-		// For now, assume it's not usdClassTransfer
-		payload["vaultAddress"] = e.vault
 	}
 
 	// Add expiration time if set

exchange_orders.go

@@ -1,6 +1,7 @@
 package hyperliquid
 
 import (
+	"encoding/json"
 	"fmt"
 )
 
@@ -39,7 +40,12 @@ type OrderStatusFilled struct {
 type OrderStatus struct {
 	Resting *OrderStatusResting `json:"resting,omitempty"`
 	Filled  *OrderStatusFilled  `json:"filled,omitempty"`
-	Error   *error              `json:"error,omitempty"`
+	Error   *string             `json:"error,omitempty"`
+}
+
+func (s *OrderStatus) String() string {
+	data, _ := json.Marshal(s)
+	return string(data)
 }
 
 type OrderResponse struct {