Fix/vaultaddr response parsing - #16
Merged
Merged
Conversation
Use fastjson.Get(...).MarshalTo(nil) for response.data instead of GetStringBytes, allowing proper unmarshalling when the field is an object or array.
Only include vaultAddress in payloads when non-empty (except usdClassTransfer handling) to prevent API 422 errors from sending an empty string.
Change OrderStatus.Error from *error to *string for proper JSON unmarshalling. Add a String() helper to OrderStatus for easier debugging/logging.
Pull Request Test Coverage Report for Build 16852915467Details
💛 - Coveralls |
Owner
|
thx! @terwey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes multiple issues in API response handling and request building:
response.dataas JSON when it’s an object or array.vaultAddressfrom payloads when empty to avoid API 422 errors.OrderStatus.Errorfrom*errorto*stringfor proper unmarshalling, and add aString()helper for easier debugging.Type of Change
Testing
make ci-fulland all checks passThe existing tests pass/fail the same as before, they are broken. Not going to fix them.
Code Quality