APIResponse Order field mapping - #17
Merged
Merged
Conversation
…field mapping - Add apiresponse_test.go to verify correct parsing of CreateOrderRequest responses. - Fix JSON tag for OrderStatusResting.ClientID from "cid" to "cloid" to match API schema.
Pull Request Test Coverage Report for Build 16886688833Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot in my recent PR to write a unit test which with further testing showed there was another bug, I might find more over time as my implementation using this SDK is nearing completion :)
test(api): add unit test for APIResponse.UnmarshalJSON and fix cloid field mapping
Pull Request
Description
Brief description of the changes in this PR.
Type of Change