Initial unit tests for Order Cancel - #21
Merged
Merged
Conversation
* Change `CancelOrderWire.OrderID` from `string` to `int64` and stop stringifying OIDs in `BulkCancel`. * Add `MixedArray.FirstError()` to parse cancel responses and return the first error (if any). * Improve cancel error handling: check `res.Ok`/`res.Status`, return API `err` or first status error. * Tests: add `TestMixedArray_FirstError` and end-to-end cancel tests (resting order cancel, double-cancel error, non-existent OID).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cancel): use int64 OrderID and surface first cancel error
CancelOrderWire.OrderIDfromstringtoint64and stop stringifying OIDs inBulkCancel.MixedArray.FirstError()to parse cancel responses and return the first error (if any).res.Ok/res.Status, return APIerror first status error.TestMixedArray_FirstErrorand end-to-end cancel tests (resting order cancel, double-cancel error, non-existent OID).Note: this depends on #20
This exposed quite a few bugs deep inside the SDK, the worst one was #20 which was a massive headache to chase. I do think adding more of these E2E tests are the way forward as they reflect the CURRENT reality and we're not just reverse engineering the Python SDK.
I'll add Cancel by CLOID tests later