[Tests] Add and fix CancelByCloid - #22
Merged
sonirico merged 1 commit intoAug 14, 2025
Merged
Conversation
…nullable; tighten error handling Use asset (not a) and cloid for CancelByCloidWire, matching the HL Python SDK. Rename CancelByCloidWire.OrderID → ClientID. Change OrderStatusResting.ClientID to *string to reflect nullable cloid. Guard nil results in BulkOrders and surface errors properly in BulkCancelByCloids (FirstError, Ok/Status checks). Add CancelByCloid tests (+ cassette) and update existing tests to use pointer ClientID. BREAKING CHANGE: OrderStatusResting.ClientID type is now *string; CancelByCloidWire field renamed to ClientID and uses JSON/Msgpack tag asset. Update callers accordingly.
sonirico
reviewed
Aug 14, 2025
sonirico
reviewed
Aug 14, 2025
| require.NoError(tt, err) | ||
| tt.Logf("cancel response: %+v", resp) | ||
|
|
||
| // // Optional second cancel to test error path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(exchange/cancel)!: correct cancelByCloid wire format; make cloid nullable; tighten error handling
Use asset (not a) and cloid for CancelByCloidWire, matching the HL Python SDK. Rename CancelByCloidWire.OrderID → ClientID.
Change OrderStatusResting.ClientID to *string to reflect nullable cloid. Guard nil results in BulkOrders and surface errors properly in BulkCancelByCloids (FirstError, Ok/Status checks). Add CancelByCloid tests (+ cassette) and update existing tests to use pointer ClientID. BREAKING CHANGE: OrderStatusResting.ClientID type is now *string; CancelByCloidWire field renamed to ClientID and uses JSON/Msgpack tag asset. Update callers accordingly.